revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-21 11:09:02 +01:00
Code Issues Releases Wiki Activity

Remove "very large change" warning from Arcanist

Browse source 
Summary: Ref T13110. We now degrade very large changes and I'm not convinced any user ever entered "n" at this prompt.

Test Plan: Ran `arc diff` to create this very revision.

Maniphest Tasks: T13110

Differential Revision: https://secure.phabricator.com/D19299
This commit is contained in:
epriestley 2018-04-05 06:33:47 -07:00
parent e44a2d3ac0
commit 73f5afd441
1 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/workflow/ArcanistDiffWorkflow.php
View file

@ -966,22 +966,6 @@ EOTEXT
throw new Exception(pht('Repository API is not supported.')); throw new Exception(pht('Repository API is not supported.'));
} }
if (count($changes) > 250) {
$message = pht(
'This diff has a very large number of changes (%s). Differential '.
'works best for changes which will receive detailed human review, '.
'and not as well for large automated changes or bulk checkins. '.
'See %s for information about reviewing big checkins. Continue anyway?',
phutil_count($changes),
'https://secure.phabricator.com/book/phabricator/article/'.
'differential_large_changes/');
if (!phutil_console_confirm($message)) {
throw new ArcanistUsageException(
pht('Aborted generation of gigantic diff.'));
}
}
$limit = 1024 * 1024 * 4; $limit = 1024 * 1024 * 4;
foreach ($changes as $change) { foreach ($changes as $change) {
$size = 0; $size = 0;