From 7547ef7e96b34a60836aed7040aa2b477091c335 Mon Sep 17 00:00:00 2001 From: Roy Williams Date: Tue, 8 Jan 2013 15:06:46 -0800 Subject: [PATCH] Pass the constructed message to the TYPE_DIFF_DIDBUILDMESSAGE event. Summary: We want to use TYPE_DIFF_DIDBUILDMESSAGE to abort arc diff when a message doesn't fit some Test Plan: Created an EventListener subscribed to TYPE_DIFF_DIDBUILDMESSAGE, validated the 'message' field was filled in Reviewers: vrana, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D4361 --- src/workflow/ArcanistDiffWorkflow.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php index 6b510863..d285f87f 100644 --- a/src/workflow/ArcanistDiffWorkflow.php +++ b/src/workflow/ArcanistDiffWorkflow.php @@ -428,7 +428,10 @@ EOTEXT $this->dispatchEvent( ArcanistEventType::TYPE_DIFF_DIDBUILDMESSAGE, - array()); + array( + 'message' => $commit_message + ) + ); if (!$this->shouldOnlyCreateDiff()) { $revision = $this->buildRevisionFromCommitMessage($commit_message);