revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-12 18:02:39 +01:00
Code Issues Releases Wiki Activity

Require PHP 5.3.0 on Windows

Browse source 
Test Plan:
  $ arc diff

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3506
This commit is contained in:
vrana 2012-09-17 13:53:04 -07:00
parent c8687a0c79
commit 754e3472e7
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
scripts/arcanist.php
View file

@ -349,7 +349,11 @@ try {
* that exclude core functionality. * that exclude core functionality.
*/ */
function sanity_check_environment() { function sanity_check_environment() {
$min_version = '5.2.3'; // NOTE: We don't have phutil_is_windows() yet here.
$is_windows = (DIRECTORY_SEPARATOR != '/');
// We use stream_socket_pair() which is not available on Windows earlier.
$min_version = ($is_windows ? '5.3.0' : '5.2.3');
$cur_version = phpversion(); $cur_version = phpversion();
if (version_compare($cur_version, $min_version, '<')) { if (version_compare($cur_version, $min_version, '<')) {
die_with_bad_php( die_with_bad_php(
@ -358,9 +362,7 @@ function sanity_check_environment() {
"'{$min_version}'."); "'{$min_version}'.");
} }
// NOTE: We don't have phutil_is_windows() yet here. if ($is_windows) {
if (DIRECTORY_SEPARATOR != '/') {
$need_functions = array( $need_functions = array(
'curl_init' => array('builtin-dll', 'php_curl.dll'), 'curl_init' => array('builtin-dll', 'php_curl.dll'),
); );