revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Fix lint errors found by Nemo

Browse source 
Test Plan: Ran a script analyzing sources by HPHP.

Reviewers: epriestley, jungejason

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2710
This commit is contained in:
vrana 2012-06-11 15:11:53 -07:00
parent c4cb7abd9a
commit 7650efc72d
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/phutil_rebuild_map.php
View file

@ -266,7 +266,7 @@ final class PhutilLibraryMapBuilder {
} }
} else { } else {
$this->log("Building library map...\n"); $this->log("Building library map...\n");
$library_map = $this->buildLibraryMap($symbol_map, $source_map); $library_map = $this->buildLibraryMap($symbol_map);
$this->log("Writing map...\n"); $this->log("Writing map...\n");
$this->writeLibraryMap($library_map); $this->writeLibraryMap($library_map);

2
src/hgdaemon/ArcanistHgProxyServer.php
View file

@ -293,7 +293,7 @@ final class ArcanistHgProxyServer {
*/ */
public function __destruct() { public function __destruct() {
if ($this->socket) { if ($this->socket) {
@stream_socket_shutdown($this->socket); @stream_socket_shutdown($this->socket, STREAM_SHUT_RDWR);
@fclose($this->socket); @fclose($this->socket);
Filesystem::remove(self::getPathToSocket($this->workingCopy)); Filesystem::remove(self::getPathToSocket($this->workingCopy));
$this->socket = null; $this->socket = null;

4
src/parser/ArcanistBundle.php
View file

@ -613,8 +613,8 @@ final class ArcanistBundle {
} }
private function buildBinaryChange(ArcanistDiffChange $change) { private function buildBinaryChange(ArcanistDiffChange $change) {
$old_phid = $change->getMetadata('old:binary-phid', null); $old_phid = $change->getMetadata('old:binary-phid');
$new_phid = $change->getMetadata('new:binary-phid', null); $new_phid = $change->getMetadata('new:binary-phid');
$type = $change->getType(); $type = $change->getType();
if ($type == ArcanistDiffChangeType::TYPE_ADD) { if ($type == ArcanistDiffChangeType::TYPE_ADD) {

2
src/repository/api/ArcanistGitAPI.php
View file

@ -236,7 +236,7 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
if (trim($object_type) !== 'commit') { if (trim($object_type) !== 'commit') {
throw new Exception( throw new Exception(
"Relative commit '{$relative}' is not the name of a commit!"); "Relative commit '{$default_relative}' is not the name of a commit!");
} }
if ($do_write) { if ($do_write) {

2
src/workflow/ArcanistPatchWorkflow.php
View file

@ -502,7 +502,7 @@ EOTEXT
$link_path = $symlink->getCurrentPath(); $link_path = $symlink->getCurrentPath();
switch ($symlink->getType()) { switch ($symlink->getType()) {
case ArcanistDiffChangeType::TYPE_ADD: case ArcanistDiffChangeType::TYPE_ADD:
case ArcanistDiffChangeType::TYPE_MODIFY: case ArcanistDiffChangeType::TYPE_CHANGE:
case ArcanistDiffChangeType::TYPE_MOVE_HERE: case ArcanistDiffChangeType::TYPE_MOVE_HERE:
case ArcanistDiffChangeType::TYPE_COPY_HERE: case ArcanistDiffChangeType::TYPE_COPY_HERE:
execx( execx(