mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 00:42:40 +01:00
Fix lint errors found by Nemo
Test Plan: Ran a script analyzing sources by HPHP. Reviewers: epriestley, jungejason Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2710
This commit is contained in:
parent
c4cb7abd9a
commit
7650efc72d
5 changed files with 6 additions and 6 deletions
|
@ -266,7 +266,7 @@ final class PhutilLibraryMapBuilder {
|
|||
}
|
||||
} else {
|
||||
$this->log("Building library map...\n");
|
||||
$library_map = $this->buildLibraryMap($symbol_map, $source_map);
|
||||
$library_map = $this->buildLibraryMap($symbol_map);
|
||||
|
||||
$this->log("Writing map...\n");
|
||||
$this->writeLibraryMap($library_map);
|
||||
|
|
|
@ -293,7 +293,7 @@ final class ArcanistHgProxyServer {
|
|||
*/
|
||||
public function __destruct() {
|
||||
if ($this->socket) {
|
||||
@stream_socket_shutdown($this->socket);
|
||||
@stream_socket_shutdown($this->socket, STREAM_SHUT_RDWR);
|
||||
@fclose($this->socket);
|
||||
Filesystem::remove(self::getPathToSocket($this->workingCopy));
|
||||
$this->socket = null;
|
||||
|
|
|
@ -613,8 +613,8 @@ final class ArcanistBundle {
|
|||
}
|
||||
|
||||
private function buildBinaryChange(ArcanistDiffChange $change) {
|
||||
$old_phid = $change->getMetadata('old:binary-phid', null);
|
||||
$new_phid = $change->getMetadata('new:binary-phid', null);
|
||||
$old_phid = $change->getMetadata('old:binary-phid');
|
||||
$new_phid = $change->getMetadata('new:binary-phid');
|
||||
|
||||
$type = $change->getType();
|
||||
if ($type == ArcanistDiffChangeType::TYPE_ADD) {
|
||||
|
|
|
@ -236,7 +236,7 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
|
|||
|
||||
if (trim($object_type) !== 'commit') {
|
||||
throw new Exception(
|
||||
"Relative commit '{$relative}' is not the name of a commit!");
|
||||
"Relative commit '{$default_relative}' is not the name of a commit!");
|
||||
}
|
||||
|
||||
if ($do_write) {
|
||||
|
|
|
@ -502,7 +502,7 @@ EOTEXT
|
|||
$link_path = $symlink->getCurrentPath();
|
||||
switch ($symlink->getType()) {
|
||||
case ArcanistDiffChangeType::TYPE_ADD:
|
||||
case ArcanistDiffChangeType::TYPE_MODIFY:
|
||||
case ArcanistDiffChangeType::TYPE_CHANGE:
|
||||
case ArcanistDiffChangeType::TYPE_MOVE_HERE:
|
||||
case ArcanistDiffChangeType::TYPE_COPY_HERE:
|
||||
execx(
|
||||
|
|
Loading…
Reference in a new issue