revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Add "Changes Planned" and "In Preparation" states for revisions

Browse source 
Summary:
Ref T2222. Discussion in T4481. Ref T2543.

Primarily, this will let me fix some of the rough edges that came out of ApplicationTransactions and state-based transitions.

I'm also adding a constant for T2543 while I'm in here.

Test Plan: Used `grep` to look for any weird special behavior, didn't see any.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2543, T2222

Differential Revision: https://secure.phabricator.com/D8400
This commit is contained in:
epriestley 2014-03-05 10:44:26 -08:00
parent fb826bbf9c
commit 7b6b24154b
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/differential/constants/ArcanistDifferentialRevisionStatus.php
View file

@ -7,14 +7,18 @@ final class ArcanistDifferentialRevisionStatus {
const ACCEPTED = 2;
const CLOSED = 3;
const ABANDONED = 4;
const CHANGES_PLANNED = 5;
const IN_PREPARATION = 6;
public static function getNameForRevisionStatus($status) {
static $map = array(
self::NEEDS_REVIEW => 'Needs Review',
self::NEEDS_REVISION => 'Needs Revision',
self::ACCEPTED => 'Accepted',
self::CLOSED => 'Closed',
self::ABANDONED => 'Abandoned',
$map = array(
self::NEEDS_REVIEW => pht('Needs Review'),
self::NEEDS_REVISION => pht('Needs Revision'),
self::ACCEPTED => pht('Accepted'),
self::CLOSED => pht('Closed'),
self::ABANDONED => pht('Abandoned'),
self::CHANGES_PLANNED => pht('Changes Planned'),
self::IN_PREPARATION => pht('In Preparation'),
);
return idx($map, coalesce($status, '?'), 'Unknown');