revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

JSHint linter issue on windows

Browse source 
Summary: On windows there is no 'which', only 'where'

Test Plan: Run JSHint linter on windows and unix-like system.

Reviewers: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3096
This commit is contained in:
Aurelijus 2012-07-30 09:21:03 +02:00
parent 333bb09e04
commit 7f4ad7117a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/lint/linter/ArcanistJSHintLinter.php
View file

@ -116,7 +116,8 @@ final class ArcanistJSHintLinter extends ArcanistLinter {
} }
// Look for globally installed JSHint // Look for globally installed JSHint
list($err) = exec_manual('which %s', $bin); $cmd = (phutil_is_windows()) ? 'where %s' : 'which %s';
list($err) = exec_manual($cmd, $bin);
if ($err) { if ($err) {
throw new ArcanistUsageException( throw new ArcanistUsageException(
"JSHint does not appear to be installed on this system. Install it ". "JSHint does not appear to be installed on this system. Install it ".