mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-29 10:12:41 +01:00
JSHint linter issue on windows
Summary: On windows there is no 'which', only 'where' Test Plan: Run JSHint linter on windows and unix-like system. Reviewers: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3096
This commit is contained in:
parent
333bb09e04
commit
7f4ad7117a
1 changed files with 2 additions and 1 deletions
|
@ -116,7 +116,8 @@ final class ArcanistJSHintLinter extends ArcanistLinter {
|
|||
}
|
||||
|
||||
// Look for globally installed JSHint
|
||||
list($err) = exec_manual('which %s', $bin);
|
||||
$cmd = (phutil_is_windows()) ? 'where %s' : 'which %s';
|
||||
list($err) = exec_manual($cmd, $bin);
|
||||
if ($err) {
|
||||
throw new ArcanistUsageException(
|
||||
"JSHint does not appear to be installed on this system. Install it ".
|
||||
|
|
Loading…
Reference in a new issue