From 807057087d65298e69bb8260db81bee1ae109084 Mon Sep 17 00:00:00 2001 From: Aiden Scandella Date: Tue, 11 Aug 2015 14:49:48 -0700 Subject: [PATCH] Restore default "yes" behavior for lint patch Summary: Fixes T9029 See T9029 for more details, but basically at some point phutil_console_confirm (which takes a `$default_no` parameter) was refactored to `$console->confirm()` which takes a `$default` parameter with semantics negated.. Test Plan: Run `arc lint` on a repository where patch is suggested. Default option should be "[Y/n]" to accept the patch. Reviewers: joshuaspence, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Maniphest Tasks: T9029 Differential Revision: https://secure.phabricator.com/D13873 --- src/workflow/ArcanistLintWorkflow.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/workflow/ArcanistLintWorkflow.php b/src/workflow/ArcanistLintWorkflow.php index f1578c37..27db427d 100644 --- a/src/workflow/ArcanistLintWorkflow.php +++ b/src/workflow/ArcanistLintWorkflow.php @@ -526,7 +526,7 @@ EOTEXT $prompt = pht( 'Apply this patch to %s?', phutil_console_format('__%s__', $result->getPath())); - if (!$console->confirm($prompt, $default_no = false)) { + if (!$console->confirm($prompt, $default = true)) { continue; } }