mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 00:42:40 +01:00
Ignore redundant PEP8 lint rule: W293
Summary: W293 reports a lint warning for the same problem that TXT6 reports a lint error for. This isn't so terrible in and of itself. However, when you are then prompted to apply a patch to fix TXT6, lint doesn't realize that the W293 warning was also handled, and still prompts you about ignoring unresolved warnings. This is misleading. Test Plan: > python pep8.py hasBlankLineWS.py hasBlankLineWS.py:3:1: W293 blank line contains whitespace > python pep8.py --ignore=W293 hasBlankLineWS.py (no output) Reviewed By: epriestley Reviewers: jungejason, epriestley CC: epriestley, aran Differential Revision: 525
This commit is contained in:
parent
499d4bd243
commit
80da1354da
1 changed files with 3 additions and 1 deletions
|
@ -41,7 +41,9 @@ class ArcanistPEP8Linter extends ArcanistLinter {
|
|||
}
|
||||
|
||||
public function getPEP8Options() {
|
||||
return null;
|
||||
// W293 (blank line contains whitespace) is redundant when used
|
||||
// alongside TXT6, causing pain to python programmers.
|
||||
return '--ignore=W293';
|
||||
}
|
||||
|
||||
public function lintPath($path) {
|
||||
|
|
Loading…
Reference in a new issue