From 828fb41ea72907e1df5ebae82392437b643a9df0 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 7 Jan 2015 07:36:07 +1100
Subject: [PATCH] Fix visibility of various `ArcanistLinter` methods

Summary: Ref T6822.

Test Plan: Visual inspection. These methods are only called from within the `ArcanistExternalLinter` and `ArcanistLinter` subclasses.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11237
---
 src/lint/linter/ArcanistCSSLintLinter.php  | 4 ++--
 src/lint/linter/ArcanistCSharpLinter.php   | 2 +-
 src/lint/linter/ArcanistChmodLinter.php    | 2 +-
 src/lint/linter/ArcanistFilenameLinter.php | 6 +++---
 src/lint/linter/ArcanistFlake8Linter.php   | 2 +-
 src/lint/linter/ArcanistHLintLinter.php    | 2 +-
 src/lint/linter/ArcanistPEP8Linter.php     | 2 +-
 src/lint/linter/ArcanistPhpLinter.php      | 2 +-
 src/lint/linter/ArcanistPhpcsLinter.php    | 2 +-
 9 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/lint/linter/ArcanistCSSLintLinter.php b/src/lint/linter/ArcanistCSSLintLinter.php
index 4c587357..45bb0f4e 100644
--- a/src/lint/linter/ArcanistCSSLintLinter.php
+++ b/src/lint/linter/ArcanistCSSLintLinter.php
@@ -25,14 +25,14 @@ final class ArcanistCSSLintLinter extends ArcanistExternalLinter {
     return 'csslint';
   }
 
-  public function getMandatoryFlags() {
+  protected function getMandatoryFlags() {
     return array(
       '--format=lint-xml',
       '--quiet',
     );
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     return $this->getDeprecatedConfiguration('lint.csslint.options', array());
   }
 
diff --git a/src/lint/linter/ArcanistCSharpLinter.php b/src/lint/linter/ArcanistCSharpLinter.php
index c43bde4b..3d466568 100644
--- a/src/lint/linter/ArcanistCSharpLinter.php
+++ b/src/lint/linter/ArcanistCSharpLinter.php
@@ -54,7 +54,7 @@ final class ArcanistCSharpLinter extends ArcanistLinter {
     parent::setLinterConfigurationValue($key, $value);
   }
 
-  public function getLintCodeFromLinterConfigurationKey($code) {
+  protected function getLintCodeFromLinterConfigurationKey($code) {
     return $code;
   }
 
diff --git a/src/lint/linter/ArcanistChmodLinter.php b/src/lint/linter/ArcanistChmodLinter.php
index 7ba4609e..cca739b7 100644
--- a/src/lint/linter/ArcanistChmodLinter.php
+++ b/src/lint/linter/ArcanistChmodLinter.php
@@ -27,7 +27,7 @@ final class ArcanistChmodLinter extends ArcanistLinter {
     return 'chmod';
   }
 
-  public function shouldLintBinaryFiles() {
+  protected function shouldLintBinaryFiles() {
     return true;
   }
 
diff --git a/src/lint/linter/ArcanistFilenameLinter.php b/src/lint/linter/ArcanistFilenameLinter.php
index e5ba19c5..b9867c5a 100644
--- a/src/lint/linter/ArcanistFilenameLinter.php
+++ b/src/lint/linter/ArcanistFilenameLinter.php
@@ -25,7 +25,7 @@ final class ArcanistFilenameLinter extends ArcanistLinter {
     return 'filename';
   }
 
-  public function shouldLintBinaryFiles() {
+  protected function shouldLintBinaryFiles() {
     return true;
   }
 
@@ -45,11 +45,11 @@ final class ArcanistFilenameLinter extends ArcanistLinter {
     }
   }
 
-  public function shouldLintDirectories() {
+  protected function shouldLintDirectories() {
     return true;
   }
 
-  public function shouldLintSymbolicLinks() {
+  protected function shouldLintSymbolicLinks() {
     return true;
   }
 
diff --git a/src/lint/linter/ArcanistFlake8Linter.php b/src/lint/linter/ArcanistFlake8Linter.php
index ed5bbdc3..658a6dd6 100644
--- a/src/lint/linter/ArcanistFlake8Linter.php
+++ b/src/lint/linter/ArcanistFlake8Linter.php
@@ -28,7 +28,7 @@ final class ArcanistFlake8Linter extends ArcanistExternalLinter {
     return 'flake8';
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     return $this->getDeprecatedConfiguration('lint.flake8.options', array());
   }
 
diff --git a/src/lint/linter/ArcanistHLintLinter.php b/src/lint/linter/ArcanistHLintLinter.php
index 4c2a5efb..312110d4 100644
--- a/src/lint/linter/ArcanistHLintLinter.php
+++ b/src/lint/linter/ArcanistHLintLinter.php
@@ -45,7 +45,7 @@ final class ArcanistHLintLinter extends ArcanistExternalLinter {
     return true;
   }
 
-  public function getMandatoryFlags() {
+  protected function getMandatoryFlags() {
     return array('--json');
   }
 
diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php
index 2d76e3f7..51608277 100644
--- a/src/lint/linter/ArcanistPEP8Linter.php
+++ b/src/lint/linter/ArcanistPEP8Linter.php
@@ -27,7 +27,7 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
     return 'pep8';
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     return $this->getDeprecatedConfiguration('lint.pep8.options', array());
   }
 
diff --git a/src/lint/linter/ArcanistPhpLinter.php b/src/lint/linter/ArcanistPhpLinter.php
index e4851e83..5a0e4dc5 100644
--- a/src/lint/linter/ArcanistPhpLinter.php
+++ b/src/lint/linter/ArcanistPhpLinter.php
@@ -26,7 +26,7 @@ final class ArcanistPhpLinter extends ArcanistExternalLinter {
     return 'php';
   }
 
-  public function getMandatoryFlags() {
+  protected function getMandatoryFlags() {
     return array('-l');
   }
 
diff --git a/src/lint/linter/ArcanistPhpcsLinter.php b/src/lint/linter/ArcanistPhpcsLinter.php
index 870d1860..e9aefe45 100644
--- a/src/lint/linter/ArcanistPhpcsLinter.php
+++ b/src/lint/linter/ArcanistPhpcsLinter.php
@@ -37,7 +37,7 @@ final class ArcanistPhpcsLinter extends ArcanistExternalLinter {
     return pht('Install PHPCS with `pear install PHP_CodeSniffer`.');
   }
 
-  public function getDefaultFlags() {
+  protected function getDefaultFlags() {
     $options = $this->getDeprecatedConfiguration('lint.phpcs.options', array());
     $standard = $this->getDeprecatedConfiguration('lint.phpcs.standard');