revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Lint the ArcanistSpellingDefaultData class.

Browse source 
Summary:
Currently, the `ArcanistSpellingDefaultData` is marked with a `@nolint` annotation. This means that it doesn't get linted by any linters. Really, the intention here was to make sure that this file isn't linted by the `ArcanistSpellingLinter` linter.

Now that the `.arclint` file is more mature, we can easily just exclude this file from being linted //only// by the spelling linter, whilst allowing other linters to run.

Test Plan: Ran `arc lint`.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9432
This commit is contained in:
Joshua Spence 2014-06-09 11:36:00 -07:00 committed by epriestley
parent 86eec5b44c
commit 833ce45155
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.arclint
View file

@ -31,7 +31,10 @@
"type": "text" "type": "text"
}, },
"spelling": { "spelling": {
"type": "spelling" "type": "spelling",
"exclude": [
"(^src/lint/linter/spelling/ArcanistSpellingDefaultData\\.php$)"
]
}, },
"xhpast": { "xhpast": {
"type": "xhpast", "type": "xhpast",

2
src/lint/linter/spelling/ArcanistSpellingDefaultData.php
View file

@ -3,8 +3,6 @@
/** /**
* Contains default spelling correction rules for ArcanistSpellingLinter. * Contains default spelling correction rules for ArcanistSpellingLinter.
* Inside its own file to keep logic of ArcanistSpellingLinter clean. * Inside its own file to keep logic of ArcanistSpellingLinter clean.
*
* @nolint
*/ */
class ArcanistSpellingDefaultData { class ArcanistSpellingDefaultData {
// From http://cpansearch.perl.org/src/APOCAL/Pod-Spell-CommonMistakes-1.000/lib/Pod/Spell/CommonMistakes/WordList.pm // From http://cpansearch.perl.org/src/APOCAL/Pod-Spell-CommonMistakes-1.000/lib/Pod/Spell/CommonMistakes/WordList.pm