revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Handle $var::method() in XHPAST linter

Browse source 
Test Plan: Didn't see a fatal in new test case.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4783
This commit is contained in:
vrana 2013-02-01 11:17:46 -08:00
parent cdb01f23a7
commit 8374dbc4e3
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -340,7 +340,10 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
$statics = $root->selectDescendantsOfType('n_CLASS_STATIC_ACCESS'); $statics = $root->selectDescendantsOfType('n_CLASS_STATIC_ACCESS');
foreach ($statics as $static) { foreach ($statics as $static) {
$name = $static->getChildOfType(0, 'n_CLASS_NAME'); $name = $static->getChildByIndex(0);
if ($name->getTypeName() != 'n_CLASS_NAME') {
continue;
}
if ($name->getConcreteString() == 'static') { if ($name->getConcreteString() == 'static') {
$this->raiseLintAtNode( $this->raiseLintAtNode(
$name, $name,

2
src/lint/linter/__tests__/xhpast/php53.lint-test
View file

@ -8,6 +8,8 @@ h(function /* ! */ () use ($c) {});
static::m(); static::m();
1 ? 1 : 2; 1 ? 1 : 2;
1 ?: 2; 1 ?: 2;
$a = 'stdClass';
$a::m();
~~~~~~~~~~ ~~~~~~~~~~
disabled:3:1 disabled:3:1
disabled:4:5 disabled:4:5