From 84210cedc6ce4ceb6b8ffcfb47fdaaa6e6d83917 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Tue, 2 Jul 2024 21:00:52 +0200 Subject: [PATCH] Declare missing class properties in ArcanistDownloadWorkflow Summary: rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties `$id`, `$saveAs`, `$show`. However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in `didParseArguments()`. Test Plan: Run PHPStan static code analysis; grep the code in this class. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25713 --- src/workflow/ArcanistDownloadWorkflow.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/workflow/ArcanistDownloadWorkflow.php b/src/workflow/ArcanistDownloadWorkflow.php index 58e566de..acbd01de 100644 --- a/src/workflow/ArcanistDownloadWorkflow.php +++ b/src/workflow/ArcanistDownloadWorkflow.php @@ -3,6 +3,10 @@ final class ArcanistDownloadWorkflow extends ArcanistArcWorkflow { + private $id; + private $saveAs; + private $show; + public function getWorkflowName() { return 'download'; }