From 8426ebc053b3c9260ab5939a42281cf4256c1a23 Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Sat, 24 Jun 2023 12:23:58 -0700
Subject: [PATCH] Fix `arc browse` for php 8.x

Summary: Ref T15064

Test Plan: Run `arc browse <filename>`, get a browser and no exception.

Reviewers: O1 Blessed Committers, valerio.bozzolan, chris

Reviewed By: O1 Blessed Committers, chris

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15064

Differential Revision: https://we.phorge.it/D25309
---
 src/ref/ArcanistRepositoryRef.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ref/ArcanistRepositoryRef.php b/src/ref/ArcanistRepositoryRef.php
index b0122ab4..38ef327b 100644
--- a/src/ref/ArcanistRepositoryRef.php
+++ b/src/ref/ArcanistRepositoryRef.php
@@ -66,7 +66,7 @@ final class ArcanistRepositoryRef
       ));
 
     foreach ($params as $key => $value) {
-      if (!strlen($value)) {
+      if ($value === null || !strlen($value)) {
         unset($params[$key]);
       }
     }