revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 00:42:40 +01:00
Code Issues Releases Wiki Activity

Fix a few edge cases for call-time pass-by-reference linting

Browse source 
Summary: Fix a few false positives.

Test Plan: Added test cases.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12134
This commit is contained in:
Joshua Spence 2015-03-23 23:21:18 +11:00
parent 1a2829d281
commit 8530cfcec1
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -3107,7 +3107,7 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
$nodes = $root->selectDescendantsOfType('n_CALL_PARAMETER_LIST');
foreach ($nodes as $node) {
$parameters = $node->selectDescendantsOfType('n_VARIABLE_REFERENCE');
$parameters = $node->getChildrenOfType('n_VARIABLE_REFERENCE');
foreach ($parameters as $parameter) {
$this->raiseLintAtNode(

3
src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test
View file

@ -20,6 +20,9 @@ while (testfunc($var1, &$var2, $var3, &$var4) === false) {}
sprintf('0%o', 0777 & $p);
$foo(&$myvar);
array_walk(array(), function() use (&$x) {});
MyClass::myfunc(array(&$x, &$y));
~~~~~~~~~~
error:2:7 XHP19
error:9:8