revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 00:02:40 +01:00
Code Issues Releases Wiki Activity

Remove "--ignore-unsound-tests" from "arc diff"

Browse source 
Summary: Ref T13544. This flag only disables a warning and should be a prompt default, not a flag.

Test Plan: Grepped for "ignore-unsound-tests", created this revision.

Maniphest Tasks: T13544

Differential Revision: https://secure.phabricator.com/D21303
This commit is contained in:
epriestley 2020-05-30 15:48:47 -07:00
parent 3ed81d35a2
commit 86471fc0fe
1 changed files with 13 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/workflow/ArcanistDiffWorkflow.php
View file

@ -295,9 +295,6 @@ EOTEXT
'skip-staging' => array( 'skip-staging' => array(
'help' => pht('Do not copy changes to the staging area.'), 'help' => pht('Do not copy changes to the staging area.'),
), ),
'ignore-unsound-tests' => array(
'help' => pht('Ignore unsound test failures without prompting.'),
),
'base' => array( 'base' => array(
'param' => 'rules', 'param' => 'rules',
'help' => pht('Additional rules for determining base revision.'), 'help' => pht('Additional rules for determining base revision.'),
@ -1238,22 +1235,20 @@ EOTEXT
pht('No unit test failures.')); pht('No unit test failures.'));
break; break;
case ArcanistUnitWorkflow::RESULT_UNSOUND: case ArcanistUnitWorkflow::RESULT_UNSOUND:
if ($this->getArgument('ignore-unsound-tests')) { $continue = phutil_console_confirm(
echo phutil_console_format( pht(
"<bg:yellow>** %s **</bg> %s\n", 'Unit test results included failures, but all failing tests '.
pht('UNIT UNSOUND'), 'are known to be unsound. Ignore unsound test failures?'));
pht( if (!$continue) {
'Unit testing raised errors, but all '. throw new ArcanistUserAbortException();
'failing tests are unsound.'));
} else {
$continue = phutil_console_confirm(
pht(
'Unit test results included failures, but all failing tests '.
'are known to be unsound. Ignore unsound test failures?'));
if (!$continue) {
throw new ArcanistUserAbortException();
}
} }
echo phutil_console_format(
"<bg:yellow>** %s **</bg> %s\n",
pht('UNIT UNSOUND'),
pht(
'Unit testing raised errors, but all '.
'failing tests are unsound.'));
break; break;
case ArcanistUnitWorkflow::RESULT_FAIL: case ArcanistUnitWorkflow::RESULT_FAIL:
$this->console->writeOut( $this->console->writeOut(