revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-18 01:38:38 +01:00
Code Issues Releases Wiki Activity

Fix "array to string" conversion error.

Browse source 
Summary: Fixes T5298. This bug was probably introduced in D9248. It looks like I forgot to update some references to `$version`.

Test Plan: Ran `arc lint --everything` in rPHU.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5298

Differential Revision: https://secure.phabricator.com/D9434
This commit is contained in:
Joshua Spence 2014-06-09 11:32:23 -07:00 • committed by epriestley
parent bec13cfea8
commit 86eec5b44c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -462,7 +462,7 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
$node, $node,
self::LINT_PHP_53_FEATURES, self::LINT_PHP_53_FEATURES,
"This codebase targets PHP 5.2.3, but `{$name}()` was not ". "This codebase targets PHP 5.2.3, but `{$name}()` was not ".
"introduced until PHP {$version}."); "introduced until PHP {$version['min']}.");
} else if (array_key_exists($name, $compat_info['params'])) { } else if (array_key_exists($name, $compat_info['params'])) {
$params = $call->getChildOfType(1, 'n_CALL_PARAMETER_LIST'); $params = $call->getChildOfType(1, 'n_CALL_PARAMETER_LIST');
foreach (array_values($params->getChildren()) as $i => $param) { foreach (array_values($params->getChildren()) as $i => $param) {
@ -495,7 +495,7 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
$node, $node,
self::LINT_PHP_53_FEATURES, self::LINT_PHP_53_FEATURES,
"This codebase targets PHP 5.2.3, but `{$name}` was not ". "This codebase targets PHP 5.2.3, but `{$name}` was not ".
"introduced until PHP {$version}."); "introduced until PHP {$version['min']}.");
} }
} }