From 8701e6c1f31ab7e3b7f35482d4bc670fde32ec99 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 2 Apr 2016 06:28:11 -0700 Subject: [PATCH] Strip tips out of commit messages from `arc backout` Summary: Fixes T10707. Currently, `arc backout` creates a commit message which includes questionably-helpful "tips" in the message itself. Strip these out. Test Plan: Used `arc backout` to revert any commit, then `git show` to see the generated message. - Before patch: included tips. - After patch: no tips. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10707 Differential Revision: https://secure.phabricator.com/D15573 --- src/workflow/ArcanistBackoutWorkflow.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/workflow/ArcanistBackoutWorkflow.php b/src/workflow/ArcanistBackoutWorkflow.php index a9564dbb..ba554405 100644 --- a/src/workflow/ArcanistBackoutWorkflow.php +++ b/src/workflow/ArcanistBackoutWorkflow.php @@ -123,6 +123,9 @@ EOTEXT $template = $this->newInteractiveEditor($template) ->setName('new-commit') ->editInteractively(); + + $template = ArcanistCommentRemover::removeComments($template); + return $template; }