revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Log slow linters using service call

Browse source 
Summary:
Following @epriestley suggestion to use PhutilServiceProfiler to log lint as a service call

Test Plan: arc lint

Reviewers: vrana

CC: phunt, aran, epriestley

Differential Revision: https://secure.phabricator.com/D4820
This commit is contained in:
François Deliège 2013-02-04 17:25:37 -08:00
parent 7a67173b97
commit 8be64ec4c6
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__phutil_library_map__.php
View file

@ -161,6 +161,7 @@ phutil_register_library_map(array(
'PhutilLintEngine' => 'lint/engine/PhutilLintEngine.php',
'PhutilUnitTestEngine' => 'unit/engine/PhutilUnitTestEngine.php',
'PhutilUnitTestEngineTestCase' => 'unit/engine/__tests__/PhutilUnitTestEngineTestCase.php',
'TimerEventType' => 'events/constant/TimerEventType.php',
'UnitTestableArcanistLintEngine' => 'lint/engine/UnitTestableArcanistLintEngine.php',
),
'function' =>
@ -288,6 +289,7 @@ phutil_register_library_map(array(
'PhutilLintEngine' => 'ArcanistLintEngine',
'PhutilUnitTestEngine' => 'ArcanistBaseUnitTestEngine',
'PhutilUnitTestEngineTestCase' => 'ArcanistTestCase',
'TimerEventType' => 'PhutilEventType',
'UnitTestableArcanistLintEngine' => 'ArcanistLintEngine',
),
));

14
src/lint/engine/ArcanistLintEngine.php
View file

@ -230,9 +230,21 @@ abstract class ArcanistLintEngine {
if ($paths) {
$linter->willLintPaths($paths);
$profiler = PhutilServiceProfiler::getInstance();
foreach ($paths as $path) {
$linter->willLintPath($path);
$linter->lintPath($path);
$call_id = $profiler->beginServiceCall(array(
'type' => 'lint',
'linter' => get_class($linter),
'path' => $path,
));
try {
$linter->lintPath($path);
} catch (Exception $ex) {
$profiler->endServiceCall($call_id, array());
throw $ex;
}
$profiler->endServiceCall($call_id, array());
if ($linter->didStopAllLinters()) {
$this->stopped[$path] = $linter_name;
}