revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-14 02:42:40 +01:00
Code Issues Releases Wiki Activity

Use CaseInsensitiveArray in ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule

Browse source 
Summary: Demonstrates the use of `CaseInsensitiveArray`. Depends on D14624.

Test Plan: Ran unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14625
This commit is contained in:
Joshua Spence 2015-12-03 08:10:30 +11:00
parent 76ae02325d
commit 8ed3c45c82
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php
View file

@ -14,21 +14,25 @@ final class ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule
} }
public function process(XHPASTNode $root) { public function process(XHPASTNode $root) {
static $cast_functions = array( static $cast_functions;
if ($cast_functions === null) {
$cast_functions = new CaseInsensitiveArray(array(
'boolval' => 'bool', 'boolval' => 'bool',
'doubleval' => 'double', 'doubleval' => 'double',
'floatval' => 'double', 'floatval' => 'double',
'intval' => 'int', 'intval' => 'int',
'strval' => 'string', 'strval' => 'string',
); ));
}
$casts = $this->getFunctionCalls($root, array_keys($cast_functions)); $casts = $this->getFunctionCalls($root, $cast_functions->getKeys());
foreach ($casts as $cast) { foreach ($casts as $cast) {
$function_name = $cast $function_name = $cast
->getChildOfType(0, 'n_SYMBOL_NAME') ->getChildOfType(0, 'n_SYMBOL_NAME')
->getConcreteString(); ->getConcreteString();
$cast_name = $cast_functions[strtolower($function_name)]; $cast_name = $cast_functions[$function_name];
$parameters = $cast->getChildOfType(1, 'n_CALL_PARAMETER_LIST'); $parameters = $cast->getChildOfType(1, 'n_CALL_PARAMETER_LIST');
$replacement = null; $replacement = null;