Use CaseInsensitiveArray in ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule

Summary: Demonstrates the use of `CaseInsensitiveArray`. Depends on D14624.

Test Plan: Ran unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14625

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

@@ -14,21 +14,25 @@ final class ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule
   }
 
   public function process(XHPASTNode $root) {
-    static $cast_functions = array(
+    static $cast_functions;
-      'boolval' => 'bool',
-      'doubleval' => 'double',
-      'floatval' => 'double',
-      'intval' => 'int',
-      'strval' => 'string',
-    );
 
-    $casts = $this->getFunctionCalls($root, array_keys($cast_functions));
+    if ($cast_functions === null) {
+      $cast_functions = new CaseInsensitiveArray(array(
+        'boolval' => 'bool',
+        'doubleval' => 'double',
+        'floatval' => 'double',
+        'intval' => 'int',
+        'strval' => 'string',
+      ));
+    }
+
+    $casts = $this->getFunctionCalls($root, $cast_functions->getKeys());
 
     foreach ($casts as $cast) {
       $function_name = $cast
         ->getChildOfType(0, 'n_SYMBOL_NAME')
         ->getConcreteString();
-      $cast_name = $cast_functions[strtolower($function_name)];
+      $cast_name = $cast_functions[$function_name];
 
       $parameters  = $cast->getChildOfType(1, 'n_CALL_PARAMETER_LIST');
       $replacement = null;