revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Use phutil functions to copy/move files

Browse source 
Summary:
The `cp` and `mv` commands, when run from a Windows
environment, error out.  Use library functions from `Filesystem`
for cross-platform compatibility.

Test Plan:
Ran `arc lint` with auto-fix lint errors on both Linux and
Windows.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Spies: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D16273
This commit is contained in:
Alex Vandiver 2016-07-11 13:39:57 -07:00
parent 4d4d16f259
commit 8f69a5c378
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/lint/ArcanistLintPatcher.php
View file

@ -42,12 +42,13 @@ final class ArcanistLintPatcher extends Phobject {
// supported under OSX. // supported under OSX.
if (Filesystem::pathExists($path)) { if (Filesystem::pathExists($path)) {
// This path may not exist if we're generating a new file. // This path may not exist if we're generating a new file.
execx('cp -p %s %s', $path, $lint); Filesystem::copyFile($path, $lint);
} }
Filesystem::writeFile($lint, $data); Filesystem::writeFile($lint, $data);
list($err) = exec_manual('mv -f %s %s', $lint, $path); try {
if ($err) { Filesystem::rename($lint, $path);
} catch (FilesystemException $e) {
throw new Exception( throw new Exception(
pht( pht(
"Unable to overwrite path '%s', patched version was left at '%s'.", "Unable to overwrite path '%s', patched version was left at '%s'.",