Finalize Arcanist Classes

Summary:
Mark all applicable Arcanist classes as "final", except PhutilLintEngine, which
needs a little finesse.

@jungejason / @nh, does this break any Facebook stuff?

Test Plan: Linter no longer raises warnings. Ran "testEverythingImplemented" in
Phabricator.

Reviewers: btrahan, jungejason, nh

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1519

src/branch/BranchInfo.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@
  * Holds information about a single git branch, and provides methods
  * for loading and display.
  */
-class BranchInfo {
+final class BranchInfo {
 
   private $branchName;
   private $currentHead = false;

src/configuration/ArcanistConfiguration.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -37,6 +37,7 @@
  *      getCustomArgumentsForCommand().
  *
  * @group config
+ * @concrete-extensible
  */
 class ArcanistConfiguration {
 

src/difference/__tests__/ArcanistDiffUtilsTestCase.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class ArcanistDiffUtilsTestCase extends ArcanistPhutilTestCase {
+final class ArcanistDiffUtilsTestCase extends ArcanistPhutilTestCase {
   public function testLevenshtein() {
     $tests = array(
       array(

src/differential/commitmessage/ArcanistDifferentialCommitMessage.php

@@ -21,7 +21,7 @@
  *
  * @group differential
  */
-class ArcanistDifferentialCommitMessage {
+final class ArcanistDifferentialCommitMessage {
 
   private $rawCorpus;
   private $revisionID;

src/differential/commitmessage/ArcanistDifferentialCommitMessageParserException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group differential
  */
-class ArcanistDifferentialCommitMessageParserException extends Exception {
+final class ArcanistDifferentialCommitMessageParserException extends Exception {
 
   private $parserErrors;
 

src/differential/revision/ArcanistDifferentialRevisionRef.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group differential
  */
-class ArcanistDifferentialRevisionRef {
+final class ArcanistDifferentialRevisionRef {
 
   protected $id;
   protected $name;

src/exception/ArcanistChooseInvalidRevisionException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,6 +21,6 @@
  *
  * @group workflow
  */
-class ArcanistChooseInvalidRevisionException extends Exception {
+final class ArcanistChooseInvalidRevisionException extends Exception {
 
 }

src/exception/ArcanistChooseNoRevisionsException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,6 +22,6 @@
  *
  * @group workflow
  */
-class ArcanistChooseNoRevisionsException extends Exception {
+final class ArcanistChooseNoRevisionsException extends Exception {
 
 }

src/exception/usage/ArcanistUsageException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@
  * than a technical problem.
  *
  * @group workflow
+ * @concrete-extensible
  */
 class ArcanistUsageException extends Exception {
 

src/exception/usage/noeffect/ArcanistNoEffectException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,5 +22,5 @@
  *
  * @group workflow
  */
-class ArcanistNoEffectException extends ArcanistUsageException {
+final class ArcanistNoEffectException extends ArcanistUsageException {
 }

src/exception/usage/noengine/ArcanistNoEngineException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,5 +21,5 @@
  *
  * @group workflow
  */
-class ArcanistNoEngineException extends ArcanistUsageException {
+final class ArcanistNoEngineException extends ArcanistUsageException {
 }

src/exception/usage/userabort/ArcanistUserAbortException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,7 +22,7 @@
  *
  * @group workflow
  */
-class ArcanistUserAbortException extends ArcanistUsageException {
+final class ArcanistUserAbortException extends ArcanistUsageException {
   public function __construct() {
     parent::__construct('User aborted the workflow.');
   }

src/lint/engine/base/ArcanistLintEngine.php

@@ -56,6 +56,7 @@
  * and Workflows} for more information about configuring lint engines.
  *
  * @group lint
+ * @stable
  */
 abstract class ArcanistLintEngine {
 

src/lint/engine/comprehensive/ComprehensiveLintEngine.php

@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ComprehensiveLintEngine extends ArcanistLintEngine {
+final class ComprehensiveLintEngine extends ArcanistLintEngine {
 
   public function buildLinters() {
     $linters = array();

src/lint/engine/example/ExampleLintEngine.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,7 +23,7 @@
  *
  * @group linter
  */
-class ExampleLintEngine extends ArcanistLintEngine {
+final class ExampleLintEngine extends ArcanistLintEngine {
 
   public function buildLinters() {
 

src/lint/engine/liberate/ArcanistLiberateLintEngine.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistLiberateLintEngine extends ArcanistLintEngine {
+final class ArcanistLiberateLintEngine extends ArcanistLintEngine {
 
   public function buildLinters() {
     // We just run the module linter, 'arc liberate' is only interested in

src/lint/engine/phutil/PhutilLintEngine.php

@@ -19,6 +19,8 @@
 /**
  * Lint engine which enforces libphutil rules.
  *
+ * TODO: Deal with PhabricatorLintEngine extending this and then finalize it.
+ *
  * @group linter
  */
 class PhutilLintEngine extends ArcanistLintEngine {

src/lint/linter/apachelicense/ArcanistApacheLicenseLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistApacheLicenseLinter extends ArcanistLicenseLinter {
+final class ArcanistApacheLicenseLinter extends ArcanistLicenseLinter {
   public function getLinterName() {
     return 'APACHELICENSE';
   }

src/lint/linter/apachelicense/__tests__/ArcanistApacheLicenseLinterTestCase.php

@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class ArcanistApacheLicenseLinterTestCase extends ArcanistLinterTestCase {
+final class ArcanistApacheLicenseLinterTestCase extends ArcanistLinterTestCase {
 
   public function testApacheLicenseLint() {
     $linter = new ArcanistApacheLicenseLinter();

src/lint/linter/base/ArcanistLinter.php

@@ -20,6 +20,7 @@
  * Implements lint rules, like syntax checks for a specific language.
  *
  * @group linter
+ * @stable
  */
 abstract class ArcanistLinter {
 

src/lint/linter/conduit/ArcanistConduitLinter.php

@@ -49,7 +49,7 @@
  * This class is intended for customization via instantiation, not via
  * subclassing.
  */
-class ArcanistConduitLinter extends ArcanistLinter {
+final class ArcanistConduitLinter extends ArcanistLinter {
   const CONDUIT_METHOD = 'lint.getalllint';
 
   private $conduitURI;

src/lint/linter/filename/ArcanistFilenameLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistFilenameLinter extends ArcanistLinter {
+final class ArcanistFilenameLinter extends ArcanistLinter {
 
   const LINT_BAD_FILENAME = 1;
 

src/lint/linter/generated/ArcanistGeneratedLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistGeneratedLinter extends ArcanistLinter {
+final class ArcanistGeneratedLinter extends ArcanistLinter {
 
   public function willLintPaths(array $paths) {
     return;

src/lint/linter/jshint/ArcanistJSHintLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -52,7 +52,7 @@
  *
  * @group linter
  */
-class ArcanistJSHintLinter extends ArcanistLinter {
+final class ArcanistJSHintLinter extends ArcanistLinter {
 
   const JSHINT_ERROR = 1;
 

src/lint/linter/nolint/ArcanistNoLintLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,7 +22,7 @@
  *
  * @group linter
  */
-class ArcanistNoLintLinter extends ArcanistLinter {
+final class ArcanistNoLintLinter extends ArcanistLinter {
   public function willLintPaths(array $paths) {
     return;
   }

src/lint/linter/pep8/ArcanistPEP8Linter.php

@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistPEP8Linter extends ArcanistLinter {
+final class ArcanistPEP8Linter extends ArcanistLinter {
 
   public function willLintPaths(array $paths) {
     return;

src/lint/linter/phutilmodule/ArcanistPhutilModuleLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistPhutilModuleLinter extends ArcanistLinter {
+final class ArcanistPhutilModuleLinter extends ArcanistLinter {
 
   const LINT_UNDECLARED_CLASS       = 1;
   const LINT_UNDECLARED_FUNCTION    = 2;

src/lint/linter/pyflakes/ArcanistPyFlakesLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistPyFlakesLinter extends ArcanistLinter {
+final class ArcanistPyFlakesLinter extends ArcanistLinter {
 
   public function willLintPaths(array $paths) {
     return;

src/lint/linter/pylint/ArcanistPyLintLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -67,7 +67,7 @@
  *
  * @group linter
  */
-class ArcanistPyLintLinter extends ArcanistLinter {
+final class ArcanistPyLintLinter extends ArcanistLinter {
 
   private function getMessageCodeSeverity($code) {
 

src/lint/linter/spelling/ArcanistSpellingLinter.php

@@ -24,7 +24,7 @@
  *
  * @group linter
  */
-class ArcanistSpellingLinter extends ArcanistLinter {
+final class ArcanistSpellingLinter extends ArcanistLinter {
 
   const LINT_SPELLING_PICKY = 0;
   const LINT_SPELLING_IMPORTANT = 1;

src/lint/linter/spelling/__tests__/ArcanistSpellingLinterTestCase.php

@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class ArcanistSpellingLinterTestCase extends ArcanistLinterTestCase {
+final class ArcanistSpellingLinterTestCase extends ArcanistLinterTestCase {
 
   public function testSpellingLint() {
     $linter = new ArcanistSpellingLinter();

src/lint/linter/text/ArcanistTextLinter.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistTextLinter extends ArcanistLinter {
+final class ArcanistTextLinter extends ArcanistLinter {
 
   const LINT_DOS_NEWLINE            = 1;
   const LINT_TAB_LITERAL            = 2;

src/lint/linter/text/__tests__/ArcanistTextLinterTestCase.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class ArcanistTextLinterTestCase extends ArcanistLinterTestCase {
+final class ArcanistTextLinterTestCase extends ArcanistLinterTestCase {
 
   public function testTextLint() {
     $linter = new ArcanistTextLinter();

src/lint/linter/xhpast/ArcanistXHPASTLinter.php

@@ -21,7 +21,7 @@
  *
  * @group linter
  */
-class ArcanistXHPASTLinter extends ArcanistLinter {
+final class ArcanistXHPASTLinter extends ArcanistLinter {
 
   protected $trees = array();
 

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLinterTestCase.php

@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class ArcanistXHPASTLinterTestCase extends ArcanistLinterTestCase {
+final class ArcanistXHPASTLinterTestCase extends ArcanistLinterTestCase {
 
   public function testXHPASTLint() {
     $linter = new ArcanistXHPASTLinter();

src/lint/message/ArcanistLintMessage.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group lint
  */
-class ArcanistLintMessage {
+final class ArcanistLintMessage {
 
   protected $path;
   protected $line;

src/lint/renderer/ArcanistLintJSONRenderer.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group lint
  */
-class ArcanistLintJSONRenderer {
+final class ArcanistLintJSONRenderer {
   const LINES_OF_CONTEXT = 3;
 
   public function renderLintResult(ArcanistLintResult $result) {

src/lint/renderer/ArcanistLintRenderer.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group lint
  */
-class ArcanistLintRenderer {
+final class ArcanistLintRenderer {
   public function renderLintResult(ArcanistLintResult $result) {
     $messages = $result->getMessages();
     $path = $result->getPath();

src/lint/renderer/ArcanistLintSummaryRenderer.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group lint
  */
-class ArcanistLintSummaryRenderer {
+final class ArcanistLintSummaryRenderer {
   public function renderLintResult(ArcanistLintResult $result) {
     $messages = $result->getMessages();
     $path = $result->getPath();

src/lint/severity/ArcanistLintSeverity.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group lint
  */
-class ArcanistLintSeverity {
+final class ArcanistLintSeverity {
 
   const SEVERITY_ADVICE       = 'advice';
   const SEVERITY_WARNING      = 'warning';

src/parser/bundle/ArcanistBundle.php

@@ -21,7 +21,7 @@
  *
  * @group diff
  */
-class ArcanistBundle {
+final class ArcanistBundle {
 
   private $changes;
   private $conduit;

src/parser/diff/ArcanistDiffParser.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group diff
  */
-class ArcanistDiffParser {
+final class ArcanistDiffParser {
 
   protected $api;
   protected $text;

src/parser/diff/__tests__/ArcanistDiffParserTestCase.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class ArcanistDiffParserTestCase extends ArcanistPhutilTestCase {
+final class ArcanistDiffParserTestCase extends ArcanistPhutilTestCase {
 
   public function testParser() {
     $root = dirname(__FILE__).'/data/';

src/parser/diff/change/ArcanistDiffChange.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group diff
  */
-class ArcanistDiffChange {
+final class ArcanistDiffChange {
 
   protected $metadata = array();
 

src/parser/diff/changetype/ArcanistDiffChangeType.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group diff
  */
-class ArcanistDiffChangeType {
+final class ArcanistDiffChangeType {
   const TYPE_ADD        = 1;
   const TYPE_CHANGE     = 2;
   const TYPE_DELETE     = 3;

src/parser/diff/hunk/ArcanistDiffHunk.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group diff
  */
-class ArcanistDiffHunk {
+final class ArcanistDiffHunk {
 
   protected $oldOffset;
   protected $oldLength;

src/parser/phutilmodule/PhutilModuleRequirements.php

@@ -21,7 +21,7 @@
  *
  * @group module
  */
-class PhutilModuleRequirements {
+final class PhutilModuleRequirements {
 
   protected $builtins = array(
     'class'       => array(),

src/repository/api/git/ArcanistGitAPI.php

@@ -21,7 +21,7 @@
  *
  * @group workingcopy
  */
-class ArcanistGitAPI extends ArcanistRepositoryAPI {
+final class ArcanistGitAPI extends ArcanistRepositoryAPI {
 
   private $status;
   private $relativeCommit = null;

src/repository/api/mercurial/ArcanistMercurialAPI.php

@@ -21,7 +21,7 @@
  *
  * @group workingcopy
  */
-class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
+final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
 
   private $status;
   private $base;

src/repository/api/subversion/ArcanistSubversionAPI.php

@@ -21,7 +21,7 @@
  *
  * @group workingcopy
  */
-class ArcanistSubversionAPI extends ArcanistRepositoryAPI {
+final class ArcanistSubversionAPI extends ArcanistRepositoryAPI {
 
   protected $svnStatus;
   protected $svnBaseRevisions;

src/repository/hookapi/subversion/ArcanistSubversionHookAPI.php

@@ -19,7 +19,7 @@
 /**
  * Interfaces with Subversion while running as a commit hook.
  */
-class ArcanistSubversionHookAPI extends ArcanistHookAPI {
+final class ArcanistSubversionHookAPI extends ArcanistHookAPI {
 
   protected $root;
   protected $transaction;

src/unit/engine/phutil/PhutilUnitTestEngine.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group unitrun
  */
-class PhutilUnitTestEngine extends ArcanistBaseUnitTestEngine {
+final class PhutilUnitTestEngine extends ArcanistBaseUnitTestEngine {
 
   public function run() {
 

src/unit/engine/phutil/__tests__/PhutilUnitTestEngineTestCase.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group testcase
  */
-class PhutilUnitTestEngineTestCase extends ArcanistPhutilTestCase {
+final class PhutilUnitTestEngineTestCase extends ArcanistPhutilTestCase {
 
   static $allTestsCounter = 0;
   static $oneTestCounter = 0;

src/unit/engine/phutil/testcase/exception/ArcanistPhutilTestTerminatedException.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,4 +21,4 @@
  *
  * @group unitrun
  */
-class ArcanistPhutilTestTerminatedException extends Exception {}
+final class ArcanistPhutilTestTerminatedException extends Exception {}

src/unit/result/ArcanistUnitTestResult.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group unit
  */
-class ArcanistUnitTestResult {
+final class ArcanistUnitTestResult {
 
   const RESULT_PASS         = 'pass';
   const RESULT_FAIL         = 'fail';

src/workflow/amend/ArcanistAmendWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistAmendWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistAmendWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/base/ArcanistBaseWorkflow.php

@@ -39,8 +39,9 @@
  *
  * @task  conduit   Conduit
  * @group workflow
+ * @stable
  */
-class ArcanistBaseWorkflow {
+abstract class ArcanistBaseWorkflow {
 
   private $conduit;
   private $conduitURI;

src/workflow/branch/ArcanistBranchWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistBranchWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistBranchWorkflow extends ArcanistBaseWorkflow {
 
   private $branches;
 

src/workflow/call-conduit/ArcanistCallConduitWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistCallConduitWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistCallConduitWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/commit/ArcanistCommitWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistCommitWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistCommitWorkflow extends ArcanistBaseWorkflow {
 
   private $revisionID;
 

src/workflow/cover/ArcanistCoverWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistCoverWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistCoverWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/diff/ArcanistDiffWorkflow.php

@@ -26,7 +26,7 @@
  *
  * @group workflow
  */
-class ArcanistDiffWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistDiffWorkflow extends ArcanistBaseWorkflow {
 
   private $hasWarnedExternals = false;
   private $unresolvedLint;

src/workflow/git-hook-pre-receive/ArcanistGitHookPreReceiveWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistGitHookPreReceiveWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistGitHookPreReceiveWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/help/ArcanistHelpWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistHelpWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistHelpWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/install-certificate/ArcanistInstallCertificateWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistInstallCertificateWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistInstallCertificateWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/land/ArcanistLandWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistLandWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistLandWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/liberate/ArcanistLiberateWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@
  *
  * @group workflow
  */
-class ArcanistLiberateWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistLiberateWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/list/ArcanistListWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistListWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistListWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/mark-committed/ArcanistMarkCommittedWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistMarkCommittedWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistMarkCommittedWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/merge/ArcanistMergeWorkflow.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,7 +22,7 @@
  *
  * @group workflow
  */
-class ArcanistMergeWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistMergeWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/shell-complete/ArcanistShellCompleteWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistShellCompleteWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistShellCompleteWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/svn-hook-pre-commit/ArcanistSvnHookPreCommitWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistSvnHookPreCommitWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistSvnHookPreCommitWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workflow/unit/ArcanistUnitWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistUnitWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistUnitWorkflow extends ArcanistBaseWorkflow {
 
   const RESULT_OKAY      = 0;
   const RESULT_UNSOUND   = 1;

src/workflow/which/ArcanistWhichWorkflow.php

@@ -21,7 +21,7 @@
  *
  * @group workflow
  */
-class ArcanistWhichWorkflow extends ArcanistBaseWorkflow {
+final class ArcanistWhichWorkflow extends ArcanistBaseWorkflow {
 
   public function getCommandHelp() {
     return phutil_console_format(<<<EOTEXT

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
  *
  * @group workingcopy
  */
-class ArcanistWorkingCopyIdentity {
+final class ArcanistWorkingCopyIdentity {
 
   protected $projectConfig;
   protected $projectRoot;