revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Remove deprecated ComprehensiveLintEngine class

Browse source 
Summary: Ref T5655. This class was deprecated in D11673.

Test Plan: Wait a few months.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D11740
This commit is contained in:
Joshua Spence 2015-04-07 07:22:59 +10:00
parent 41ddd34aeb
commit 92713cf922
3 changed files with 1 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__phutil_library_map__.php
View file

@ -211,7 +211,6 @@ phutil_register_library_map(array(
'ArcanistXMLLinterTestCase' => 'lint/linter/__tests__/ArcanistXMLLinterTestCase.php', 'ArcanistXMLLinterTestCase' => 'lint/linter/__tests__/ArcanistXMLLinterTestCase.php',
'ArcanistXUnitTestResultParser' => 'unit/parser/ArcanistXUnitTestResultParser.php', 'ArcanistXUnitTestResultParser' => 'unit/parser/ArcanistXUnitTestResultParser.php',
'CSharpToolsTestEngine' => 'unit/engine/CSharpToolsTestEngine.php', 'CSharpToolsTestEngine' => 'unit/engine/CSharpToolsTestEngine.php',
'ComprehensiveLintEngine' => 'lint/engine/ComprehensiveLintEngine.php',
'NoseTestEngine' => 'unit/engine/NoseTestEngine.php', 'NoseTestEngine' => 'unit/engine/NoseTestEngine.php',
'PhpunitTestEngine' => 'unit/engine/PhpunitTestEngine.php', 'PhpunitTestEngine' => 'unit/engine/PhpunitTestEngine.php',
'PhpunitTestEngineTestCase' => 'unit/engine/__tests__/PhpunitTestEngineTestCase.php', 'PhpunitTestEngineTestCase' => 'unit/engine/__tests__/PhpunitTestEngineTestCase.php',
@ -390,7 +389,6 @@ phutil_register_library_map(array(
'ArcanistXMLLinter' => 'ArcanistLinter', 'ArcanistXMLLinter' => 'ArcanistLinter',
'ArcanistXMLLinterTestCase' => 'ArcanistLinterTestCase', 'ArcanistXMLLinterTestCase' => 'ArcanistLinterTestCase',
'CSharpToolsTestEngine' => 'XUnitTestEngine', 'CSharpToolsTestEngine' => 'XUnitTestEngine',
'ComprehensiveLintEngine' => 'ArcanistComprehensiveLintEngine',
'NoseTestEngine' => 'ArcanistUnitTestEngine', 'NoseTestEngine' => 'ArcanistUnitTestEngine',
'PhpunitTestEngine' => 'ArcanistUnitTestEngine', 'PhpunitTestEngine' => 'ArcanistUnitTestEngine',
'PhpunitTestEngineTestCase' => 'ArcanistTestCase', 'PhpunitTestEngineTestCase' => 'ArcanistTestCase',

4
src/lint/engine/ArcanistComprehensiveLintEngine.php
View file

@ -2,10 +2,8 @@
/** /**
* Basic lint engine which just applies several linters based on the file types. * Basic lint engine which just applies several linters based on the file types.
*
* @todo Should be final but isn't because of @{class:ComprehensiveLintEngine}.
*/ */
class ArcanistComprehensiveLintEngine extends ArcanistLintEngine { final class ArcanistComprehensiveLintEngine extends ArcanistLintEngine {
public function buildLinters() { public function buildLinters() {
$linters = array(); $linters = array();

15
src/lint/engine/ComprehensiveLintEngine.php
View file

@ -1,15 +0,0 @@
<?php
/**
* @deprecated
*/
final class ComprehensiveLintEngine extends ArcanistComprehensiveLintEngine {
public function buildLinters() {
phutil_deprecated(
__CLASS__,
'You should use `ArcanistComprehensiveLintEngine` instead.');
parent::buildLinters();
}
}