revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Use "differential.query", not "differential.find", in "arc branch"

Browse source 
Summary: find is deprecated, query is new hotness.

Test Plan: Ran "arc branch", got identical output.

Reviewers: nh, btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1646
This commit is contained in:
epriestley 2012-02-20 12:51:08 -08:00
parent 506e795fda
commit 964260b1e0
2 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/workflow/branch/ArcanistBranchWorkflow.php
View file

@ -104,18 +104,12 @@ EOTEXT
*/
private function loadDifferentialStatuses($rev_ids) {
$conduit = $this->getConduit();
$revision_future = $conduit->callMethod(
'differential.find',
$revisions = $conduit->callMethodSynchronous(
'differential.query',
array(
'guids' => $rev_ids,
'query' => 'revision-ids',
'ids' => $rev_ids,
));
$revisions = array();
foreach ($revision_future->resolve() as $revision_dict) {
$revisions[] = ArcanistDifferentialRevisionRef::newFromDictionary(
$revision_dict);
}
$statuses = mpull($revisions, 'getStatusName', 'getId');
$statuses = ipull($revisions, 'statusName', 'id');
return $statuses;
}

1
src/workflow/branch/__init__.php
View file

@ -7,7 +7,6 @@
phutil_require_module('arcanist', 'branch');
phutil_require_module('arcanist', 'differential/revision');
phutil_require_module('arcanist', 'exception/usage');
phutil_require_module('arcanist', 'workflow/base');