1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-08 16:02:39 +01:00

Preserve the exit code of the diff command in binary_safe_diff.sh

Summary:
Some versions of Subversion (1.9 in any case, maybe others) will
duplicate diff headers, if the diff command run through --diff-cmd
returns 0.

This lead to T9970, where the addition of a new file with properties
only shows the properties themselves in the review, not the content of
the new file.

Test Plan: This is a trivial change, is a test needed at all?

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: stevenh, Korvin, eadler

Differential Revision: https://secure.phabricator.com/D14755
This commit is contained in:
Dimitry Andric 2015-12-13 02:21:43 -08:00 committed by epriestley
parent 74c7495b1a
commit 97056a3b85

View file

@ -1,6 +1,8 @@
#!/bin/sh #!/bin/sh
diff "$@" diff "$@"
if [ "$?" = "2" ]; then RES="$?"
if [ "$RES" = "2" ]; then
exit 1 exit 1
fi fi
exit "$RES"