From 97651311bddb6de94305e730ca4350b5b1a2a0c2 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 25 Sep 2018 15:26:00 -0700 Subject: [PATCH] [Wilds] Fix some minor classtree issues identified by unit tests Summary: Ref T13098. I eventually got unit tests sort-of-almost running and they caught these two issues. Since the tests don't get very far with these classtree problems, just fix them up now so when `arc unit` actually runs later on it can meaningfully run tests. Test Plan: Ran `arc unit`, after other changes let it run, and saw fewer "class doesn't implement every abstract method" issues. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13098 Differential Revision: https://secure.phabricator.com/D19708 --- src/config/option/ArcanistWildConfigOption.php | 4 ++++ src/config/source/ArcanistFileConfigurationSource.php | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/config/option/ArcanistWildConfigOption.php b/src/config/option/ArcanistWildConfigOption.php index aff4c97a..91e974e6 100644 --- a/src/config/option/ArcanistWildConfigOption.php +++ b/src/config/option/ArcanistWildConfigOption.php @@ -32,4 +32,8 @@ final class ArcanistWildConfigOption return $value; } + public function getStorageValueFromValue($value) { + return $value; + } + } diff --git a/src/config/source/ArcanistFileConfigurationSource.php b/src/config/source/ArcanistFileConfigurationSource.php index 22fb1d81..947750aa 100644 --- a/src/config/source/ArcanistFileConfigurationSource.php +++ b/src/config/source/ArcanistFileConfigurationSource.php @@ -1,11 +1,10 @@