revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-11 08:06:12 +01:00
Code Issues Releases Wiki Activity

[Wilds] Fix some minor classtree issues identified by unit tests

Browse source 
Summary: Ref T13098. I eventually got unit tests sort-of-almost running and they caught these two issues. Since the tests don't get very far with these classtree problems, just fix them up now so when `arc unit` actually runs later on it can meaningfully run tests.

Test Plan: Ran `arc unit`, after other changes let it run, and saw fewer "class doesn't implement every abstract method" issues.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19708
This commit is contained in:
epriestley 2018-09-25 15:26:00 -07:00
parent 4c4fd6fd23
commit 97651311bd
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/config/option/ArcanistWildConfigOption.php
View file

@ -32,4 +32,8 @@ final class ArcanistWildConfigOption
return $value; return $value;
} }
public function getStorageValueFromValue($value) {
return $value;
}
} }

3
src/config/source/ArcanistFileConfigurationSource.php
View file

@ -1,11 +1,10 @@
<?php <?php
final class ArcanistFileConfigurationSource final class ArcanistFileConfigurationSource
extends ArcanistConfigurationSource { extends ArcanistFilesystemConfigurationSource {
public function getFileKindDisplayName() { public function getFileKindDisplayName() {
return pht('Config File'); return pht('Config File');
} }
} }