Remove the ArcanistArcanistLinterTestCase

Summary: I don't think that this provides too much value. I think that we should rework this to be inferred from the `.arcconfig` file perhaps?

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11662

src/__phutil_library_map__.php

@@ -12,7 +12,6 @@ phutil_register_library_map(array(
     'ArcanistAliasWorkflow' => 'workflow/ArcanistAliasWorkflow.php',
     'ArcanistAmendWorkflow' => 'workflow/ArcanistAmendWorkflow.php',
     'ArcanistAnoidWorkflow' => 'workflow/ArcanistAnoidWorkflow.php',
-    'ArcanistArcanistLinterTestCase' => 'lint/linter/__tests__/ArcanistArcanistLinterTestCase.php',
     'ArcanistBackoutWorkflow' => 'workflow/ArcanistBackoutWorkflow.php',
     'ArcanistBaseCommitParser' => 'parser/ArcanistBaseCommitParser.php',
     'ArcanistBaseCommitParserTestCase' => 'parser/__tests__/ArcanistBaseCommitParserTestCase.php',
@@ -223,7 +222,6 @@ phutil_register_library_map(array(
     'ArcanistAliasWorkflow' => 'ArcanistWorkflow',
     'ArcanistAmendWorkflow' => 'ArcanistWorkflow',
     'ArcanistAnoidWorkflow' => 'ArcanistWorkflow',
-    'ArcanistArcanistLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistBackoutWorkflow' => 'ArcanistWorkflow',
     'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase',
     'ArcanistBaseUnitTestEngine' => 'ArcanistUnitTestEngine',
@@ -241,7 +239,7 @@ phutil_register_library_map(array(
     'ArcanistCapabilityNotSupportedException' => 'Exception',
     'ArcanistCheckstyleXMLLintRenderer' => 'ArcanistLintRenderer',
     'ArcanistChmodLinter' => 'ArcanistLinter',
-    'ArcanistChmodLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistChmodLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistCloseRevisionWorkflow' => 'ArcanistWorkflow',
     'ArcanistCloseWorkflow' => 'ArcanistWorkflow',
     'ArcanistClosureLinter' => 'ArcanistExternalLinter',
@@ -250,7 +248,7 @@ phutil_register_library_map(array(
     'ArcanistCoffeeLintLinterTestCase' => 'ArcanistExternalLinterTestCase',
     'ArcanistCommentRemoverTestCase' => 'ArcanistTestCase',
     'ArcanistCommitLinter' => 'ArcanistLinter',
-    'ArcanistCommitLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistCommitLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistCommitWorkflow' => 'ArcanistWorkflow',
     'ArcanistCompilerLikeLintRenderer' => 'ArcanistLintRenderer',
     'ArcanistConduitLinter' => 'ArcanistLinter',
@@ -273,13 +271,13 @@ phutil_register_library_map(array(
     'ArcanistExternalLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistFeatureWorkflow' => 'ArcanistWorkflow',
     'ArcanistFilenameLinter' => 'ArcanistLinter',
-    'ArcanistFilenameLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistFilenameLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistFlagWorkflow' => 'ArcanistWorkflow',
     'ArcanistFlake8Linter' => 'ArcanistExternalLinter',
     'ArcanistFlake8LinterTestCase' => 'ArcanistExternalLinterTestCase',
     'ArcanistFutureLinter' => 'ArcanistLinter',
     'ArcanistGeneratedLinter' => 'ArcanistLinter',
-    'ArcanistGeneratedLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistGeneratedLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistGetConfigWorkflow' => 'ArcanistWorkflow',
     'ArcanistGitAPI' => 'ArcanistRepositoryAPI',
     'ArcanistGitHookPreReceiveWorkflow' => 'ArcanistWorkflow',
@@ -299,7 +297,7 @@ phutil_register_library_map(array(
     'ArcanistJSONLintLinterTestCase' => 'ArcanistExternalLinterTestCase',
     'ArcanistJSONLintRenderer' => 'ArcanistLintRenderer',
     'ArcanistJSONLinter' => 'ArcanistLinter',
-    'ArcanistJSONLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistJSONLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistJscsLinter' => 'ArcanistExternalLinter',
     'ArcanistJscsLinterTestCase' => 'ArcanistExternalLinterTestCase',
     'ArcanistLandWorkflow' => 'ArcanistWorkflow',
@@ -314,12 +312,12 @@ phutil_register_library_map(array(
     'ArcanistMercurialAPI' => 'ArcanistRepositoryAPI',
     'ArcanistMercurialParserTestCase' => 'ArcanistTestCase',
     'ArcanistMergeConflictLinter' => 'ArcanistLinter',
-    'ArcanistMergeConflictLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistMergeConflictLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistMissingLinterException' => 'Exception',
     'ArcanistNoEffectException' => 'ArcanistUsageException',
     'ArcanistNoEngineException' => 'ArcanistUsageException',
     'ArcanistNoLintLinter' => 'ArcanistLinter',
-    'ArcanistNoLintLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistNoLintLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistNoneLintRenderer' => 'ArcanistLintRenderer',
     'ArcanistPEP8Linter' => 'ArcanistExternalLinter',
     'ArcanistPEP8LinterTestCase' => 'ArcanistExternalLinterTestCase',
@@ -336,7 +334,7 @@ phutil_register_library_map(array(
     'ArcanistPhutilTestSkippedException' => 'Exception',
     'ArcanistPhutilTestTerminatedException' => 'Exception',
     'ArcanistPhutilXHPASTLinter' => 'ArcanistBaseXHPASTLinter',
-    'ArcanistPhutilXHPASTLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistPhutilXHPASTLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistPuppetLintLinter' => 'ArcanistExternalLinter',
     'ArcanistPuppetLintLinterTestCase' => 'ArcanistExternalLinterTestCase',
     'ArcanistPyFlakesLinter' => 'ArcanistExternalLinter',
@@ -353,7 +351,7 @@ phutil_register_library_map(array(
     'ArcanistShellCompleteWorkflow' => 'ArcanistWorkflow',
     'ArcanistSingleLintEngine' => 'ArcanistLintEngine',
     'ArcanistSpellingLinter' => 'ArcanistLinter',
-    'ArcanistSpellingLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistSpellingLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistStartWorkflow' => 'ArcanistPhrequentWorkflow',
     'ArcanistStopWorkflow' => 'ArcanistPhrequentWorkflow',
     'ArcanistSubversionAPI' => 'ArcanistRepositoryAPI',
@@ -363,7 +361,7 @@ phutil_register_library_map(array(
     'ArcanistTasksWorkflow' => 'ArcanistWorkflow',
     'ArcanistTestCase' => 'ArcanistPhutilTestCase',
     'ArcanistTextLinter' => 'ArcanistLinter',
-    'ArcanistTextLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistTextLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistTimeWorkflow' => 'ArcanistPhrequentWorkflow',
     'ArcanistTodoWorkflow' => 'ArcanistWorkflow',
     'ArcanistUncommittedChangesException' => 'ArcanistUsageException',
@@ -380,9 +378,9 @@ phutil_register_library_map(array(
     'ArcanistXHPASTLintNamingHookTestCase' => 'ArcanistTestCase',
     'ArcanistXHPASTLintTestSwitchHook' => 'ArcanistXHPASTLintSwitchHook',
     'ArcanistXHPASTLinter' => 'ArcanistBaseXHPASTLinter',
-    'ArcanistXHPASTLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistXHPASTLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistXMLLinter' => 'ArcanistLinter',
-    'ArcanistXMLLinterTestCase' => 'ArcanistArcanistLinterTestCase',
+    'ArcanistXMLLinterTestCase' => 'ArcanistLinterTestCase',
     'CSharpToolsTestEngine' => 'XUnitTestEngine',
     'ComprehensiveLintEngine' => 'ArcanistLintEngine',
     'NoseTestEngine' => 'ArcanistUnitTestEngine',

src/lint/linter/__tests__/ArcanistArcanistLinterTestCase.php

@@ -1,14 +0,0 @@
-<?php
-
-abstract class ArcanistArcanistLinterTestCase extends ArcanistLinterTestCase {
-
-  protected function getLink($method) {
-    // This could be converted to trait from ArcanistTestCase.
-    $arcanist_project = 'PHID-APRJ-703e0b140530f17ede30';
-    return
-      'https://secure.phabricator.com/diffusion/symbol/'.$method.
-      '/?lang=php&projects='.$arcanist_project.
-      '&jump=true&context='.get_class($this);
-  }
-
-}

src/lint/linter/__tests__/ArcanistChmodLinterTestCase.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ArcanistChmodLinterTestCase extends ArcanistArcanistLinterTestCase {
+final class ArcanistChmodLinterTestCase extends ArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/chmod/');

src/lint/linter/__tests__/ArcanistCommitLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistCommitLinterTestCase
+final class ArcanistCommitLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     return $this->executeTestsInDirectory(dirname(__FILE__).'/commit/');

src/lint/linter/__tests__/ArcanistFilenameLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistFilenameLinterTestCase
+final class ArcanistFilenameLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/filename/');

src/lint/linter/__tests__/ArcanistGeneratedLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistGeneratedLinterTestCase
+final class ArcanistGeneratedLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     return $this->executeTestsInDirectory(dirname(__FILE__).'/generated/');

src/lint/linter/__tests__/ArcanistJSONLinterTestCase.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ArcanistJSONLinterTestCase extends ArcanistArcanistLinterTestCase {
+final class ArcanistJSONLinterTestCase extends ArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/jsonlint/');

src/lint/linter/__tests__/ArcanistMergeConflictLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistMergeConflictLinterTestCase
+final class ArcanistMergeConflictLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/mergeconflict/');

src/lint/linter/__tests__/ArcanistNoLintLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistNoLintLinterTestCase
+final class ArcanistNoLintLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     return $this->executeTestsInDirectory(dirname(__FILE__).'/nolint/');

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistPhutilXHPASTLinterTestCase
+final class ArcanistPhutilXHPASTLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     $linter = new ArcanistPhutilXHPASTLinter();

src/lint/linter/__tests__/ArcanistSpellingLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistSpellingLinterTestCase
+final class ArcanistSpellingLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     $linter = new ArcanistSpellingLinter();

src/lint/linter/__tests__/ArcanistTextLinterTestCase.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ArcanistTextLinterTestCase extends ArcanistArcanistLinterTestCase {
+final class ArcanistTextLinterTestCase extends ArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/text/');

src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php

@@ -1,7 +1,6 @@
 <?php
 
-final class ArcanistXHPASTLinterTestCase
+final class ArcanistXHPASTLinterTestCase extends ArcanistLinterTestCase {
-  extends ArcanistArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/xhpast/');

src/lint/linter/__tests__/ArcanistXMLLinterTestCase.php

@@ -4,7 +4,7 @@
  * Test cases were mostly taken from
  * https://git.gnome.org/browse/libxml2/tree/test.
  */
-final class ArcanistXMLLinterTestCase extends ArcanistArcanistLinterTestCase {
+final class ArcanistXMLLinterTestCase extends ArcanistLinterTestCase {
 
   public function testLinter() {
     $this->executeTestsInDirectory(dirname(__FILE__).'/xml/');