From 999eb93765688a788b77513334cc9a651726c94b Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Wed, 8 Jul 2015 20:03:00 +1000
Subject: [PATCH] Remove verbose output from `arc lint --trace`

Summary: I think that this output was used during the early stage of `ArcanistConfigurationDrivenLintEngine`, but I question it's value nowadays. In particular, I find that this output makes the output of `arc lint --trace` significantly less useful.

Test Plan: Ran `./bin/arc lint --trace` and saw useful output.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13593
---
 .../ArcanistConfigurationDrivenLintEngine.php | 41 -------------------
 1 file changed, 41 deletions(-)

diff --git a/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php b/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
index 73651083..531ccf6c 100644
--- a/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
+++ b/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
@@ -179,79 +179,38 @@ final class ArcanistConfigurationDrivenLintEngine extends ArcanistLintEngine {
 
     $match = array();
     foreach ($paths as $path) {
-      $console->writeLog("%s\n", pht("Examining path '%s'...", $path));
-
       $keep = false;
       if (!$include) {
         $keep = true;
-        $console->writeLog(
-          "  %s\n",
-          pht('Including path by default because there is no "include" rule.'));
       } else {
-        $console->writeLog(
-          "  %s\n",
-          pht('Testing "include" rules.'));
         foreach ($include as $rule) {
           if (preg_match($rule, $path)) {
             $keep = true;
-            $console->writeLog(
-              "  %s\n",
-              pht('Path matches include rule: %s.', $rule));
             break;
-          } else {
-            $console->writeLog(
-              "  %s\n",
-              pht('Path does not match include rule: %s', $rule));
           }
         }
       }
 
       if (!$keep) {
-        $console->writeLog(
-          "  %s\n",
-          pht('Path does not match any include rules, discarding.'));
         continue;
       }
 
       if ($exclude) {
-        $console->writeLog(
-          "  %s\n",
-          pht('Testing "exclude" rules.'));
         foreach ($exclude as $rule) {
           if (preg_match($rule, $path)) {
-            $console->writeLog(
-              "  %s\n",
-              pht('Path matches "exclude" rule: %s.', $rule));
             continue 2;
-          } else {
-            $console->writeLog(
-              "  %s\n",
-              pht('Path does not match "exclude" rule: %s.', $rule));
           }
         }
       }
 
       if ($global_exclude) {
-        $console->writeLog(
-          "  %s\n",
-          pht('Testing global "exclude" rules.'));
         foreach ($global_exclude as $rule) {
           if (preg_match($rule, $path)) {
-            $console->writeLog(
-              "  %s\n",
-              pht('Path matches global "exclude" rule: %s.', $rule));
             continue 2;
-          } else {
-            $console->writeLog(
-              "  %s\n",
-              pht('Path does not match global "exclude" rule: %s.', $rule));
           }
         }
       }
 
-      $console->writeLog(
-        "  %s\n",
-        pht('Path matches.'));
       $match[] = $path;
     }