From 9b7c6786cdc9694b45907ecb46154befbd605a0d Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Sun, 24 May 2015 07:45:01 +1000 Subject: [PATCH] Change visibility of some linter methods Summary: Change the visibility of the `raiseLintAtSomething` methods, mainly to allow linter rules to raise linter messages (see D10541). Test Plan: `arc unit` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12976 --- src/lint/linter/ArcanistBaseXHPASTLinter.php | 4 ++-- src/lint/linter/ArcanistLinter.php | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lint/linter/ArcanistBaseXHPASTLinter.php b/src/lint/linter/ArcanistBaseXHPASTLinter.php index c420738e..c31abcb3 100644 --- a/src/lint/linter/ArcanistBaseXHPASTLinter.php +++ b/src/lint/linter/ArcanistBaseXHPASTLinter.php @@ -23,7 +23,7 @@ abstract class ArcanistBaseXHPASTLinter extends ArcanistFutureLinter { return implode('-', $parts); } - final protected function raiseLintAtToken( + final public function raiseLintAtToken( XHPASTToken $token, $code, $desc, @@ -36,7 +36,7 @@ abstract class ArcanistBaseXHPASTLinter extends ArcanistFutureLinter { $replace); } - final protected function raiseLintAtNode( + final public function raiseLintAtNode( XHPASTNode $node, $code, $desc, diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php index 6a1af25c..9eb92aaa 100644 --- a/src/lint/linter/ArcanistLinter.php +++ b/src/lint/linter/ArcanistLinter.php @@ -416,7 +416,7 @@ abstract class ArcanistLinter { return $this->messages; } - final protected function raiseLintAtLine( + final public function raiseLintAtLine( $line, $char, $code, @@ -438,11 +438,11 @@ abstract class ArcanistLinter { return $this->addLintMessage($message); } - final protected function raiseLintAtPath($code, $desc) { + final public function raiseLintAtPath($code, $desc) { return $this->raiseLintAtLine(null, null, $code, $desc, null, null); } - final protected function raiseLintAtOffset( + final public function raiseLintAtOffset( $offset, $code, $desc,