revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Show a better expected vs actual for tests with large output

Browse source 
Summary: When tests have a lot of output, show a diff of the expected/actual.

Test Plan: Used this when developing D2016 to examine large output usefully.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2017
This commit is contained in:
epriestley 2012-03-26 09:43:47 -07:00
parent b67ce7e534
commit 9db7f294ef
2 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/unit/engine/phutil/testcase/ArcanistPhutilTestCase.php
View file

@ -79,17 +79,17 @@ abstract class ArcanistPhutilTestCase {
$output .= "\n"; $output .= "\n";
if (strpos($expect, "\n") !== false) { if (strpos($expect, "\n") === false && strpos($result, "\n") === false) {
$expect = "\n{$expect}"; $output .= "Expected: {$expect}\n";
$output .= "Actual: {$result}";
} else {
$output .= "Expected vs Actual Output Diff\n";
$output .= ArcanistDiffUtils::renderDifferences(
$expect,
$result,
$lines = 0xFFFF);
} }
if (strpos($result, "\n") !== false) {
$result = "\n{$result}";
}
$output .= "Expected: {$expect}\n";
$output .= "Actual: {$result}";
$this->failTest($output); $this->failTest($output);
throw new ArcanistPhutilTestTerminatedException($output); throw new ArcanistPhutilTestTerminatedException($output);
} }

1
src/unit/engine/phutil/testcase/__init__.php
View file

@ -6,6 +6,7 @@
phutil_require_module('arcanist', 'difference');
phutil_require_module('arcanist', 'unit/engine/phutil/testcase/exception'); phutil_require_module('arcanist', 'unit/engine/phutil/testcase/exception');
phutil_require_module('arcanist', 'unit/result'); phutil_require_module('arcanist', 'unit/result');