From 9e6f876a68b47e053e6b7d13eace15e1df7d9554 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 5 Jan 2015 06:48:32 +1100 Subject: [PATCH] Export namespace in `ArcanistUnitTestResult` dictionary Summary: D7952 added namespaces to `ArcanistUnitTestResult` but these are not exported and thus don't get sent from client to server. Test Plan: Uploaded a diff and inspected the contents of the `phabricator_differential.differential_diffproperty` table. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11208 --- src/unit/ArcanistUnitTestResult.php | 1 + src/workflow/ArcanistDiffWorkflow.php | 9 +-------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/unit/ArcanistUnitTestResult.php b/src/unit/ArcanistUnitTestResult.php index 9628b591..0a8d6e63 100644 --- a/src/unit/ArcanistUnitTestResult.php +++ b/src/unit/ArcanistUnitTestResult.php @@ -122,6 +122,7 @@ final class ArcanistUnitTestResult { public function toDictionary() { return array( + 'namespace' => $this->getNamespace(), 'name' => $this->getName(), 'link' => $this->getLink(), 'result' => $this->getResult(), diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php index 231732eb..6513ef9b 100644 --- a/src/workflow/ArcanistDiffWorkflow.php +++ b/src/workflow/ArcanistDiffWorkflow.php @@ -1333,14 +1333,7 @@ EOTEXT $this->testResults = array(); foreach ($unit_workflow->getTestResults() as $test) { - $this->testResults[] = array( - 'name' => $test->getName(), - 'link' => $test->getLink(), - 'result' => $test->getResult(), - 'userdata' => $test->getUserData(), - 'coverage' => $test->getCoverage(), - 'extra' => $test->getExtraData(), - ); + $this->testResults[] = $test->toDictionary(); } return $unit_result;