revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 16:52:40 +01:00
Code Issues Releases Wiki Activity

Lint for PHP 5.3 on Windows

Browse source 
Test Plan: Linted `FileFinder`.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5972
This commit is contained in:
Jakub Vrana 2013-05-19 11:00:08 -07:00
parent a45ef76a8f
commit a1c0ba785d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -439,12 +439,12 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
"of `{$name}()` was not introduced until PHP {$version}."); "of `{$name}()` was not introduced until PHP {$version}.");
} }
} }
} else if ($windows_version !== null) { } else if (version_compare($windows_version, '5.3.0') > 0) {
$this->raiseLintAtNode( $this->raiseLintAtNode(
$node, $node,
self::LINT_PHP_53_FEATURES, self::LINT_PHP_53_FEATURES,
"This codebase targets PHP 5.2.3, but `{$name}()` is not available ". "This codebase targets PHP 5.3.0 on Windows, but `{$name}()` is not ".
"on Windows". "available there.".
($windows_version ? " until PHP {$windows_version}" : "")."."); ($windows_version ? " until PHP {$windows_version}" : "").".");
} }
} }