revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 00:42:40 +01:00
Code Issues Releases Wiki Activity

Call phutil_passthru() instead of passthru() in liberate

Browse source 
Summary: Solves T1085 and is probably slightly better anyway.

Test Plan:
  arc liberate

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Maniphest Tasks: T1085

Differential Revision: https://secure.phabricator.com/D2151
This commit is contained in:
vrana 2012-04-08 01:29:28 -07:00
parent 2c599f8928
commit a2c125d4ef
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workflow/liberate/ArcanistLiberateWorkflow.php
View file

@ -162,9 +162,7 @@ EOTEXT
echo "Verifying library...\n";
$err = 0;
$cmd = csprintf('%s liberate --verify -- %s', $arc_bin, $path);
passthru($cmd, $err);
$err = phutil_passthru('%s liberate --verify -- %s', $arc_bin, $path);
$do_update = (!$err || $this->getArgument('force-update'));

1
src/workflow/liberate/__init__.php
View file

@ -20,7 +20,6 @@ phutil_require_module('phutil', 'filesystem/filefinder');
phutil_require_module('phutil', 'future/exec');
phutil_require_module('phutil', 'moduleutils');
phutil_require_module('phutil', 'utils');
phutil_require_module('phutil', 'xsprintf/csprintf');
phutil_require_source('ArcanistLiberateWorkflow.php');