mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-29 18:22:41 +01:00
Delete newLintAtLine()
Summary: Nobody needs it because `raiseLintAtLine()` returns the message. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4870
This commit is contained in:
parent
7f81058ead
commit
a3e0c26ea8
1 changed files with 8 additions and 12 deletions
|
@ -151,17 +151,6 @@ abstract class ArcanistLinter {
|
||||||
return $this->messages;
|
return $this->messages;
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function newLintAtLine($line, $char, $code, $desc) {
|
|
||||||
return id(new ArcanistLintMessage())
|
|
||||||
->setPath($this->getActivePath())
|
|
||||||
->setLine($line)
|
|
||||||
->setChar($char)
|
|
||||||
->setCode($this->getLintMessageFullCode($code))
|
|
||||||
->setSeverity($this->getLintMessageSeverity($code))
|
|
||||||
->setName($this->getLintMessageName($code))
|
|
||||||
->setDescription($desc);
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function raiseLintAtLine(
|
protected function raiseLintAtLine(
|
||||||
$line,
|
$line,
|
||||||
$char,
|
$char,
|
||||||
|
@ -170,7 +159,14 @@ abstract class ArcanistLinter {
|
||||||
$original = null,
|
$original = null,
|
||||||
$replacement = null) {
|
$replacement = null) {
|
||||||
|
|
||||||
$message = $this->newLintAtLine($line, $char, $code, $desc)
|
$message = id(new ArcanistLintMessage())
|
||||||
|
->setPath($this->getActivePath())
|
||||||
|
->setLine($line)
|
||||||
|
->setChar($char)
|
||||||
|
->setCode($this->getLintMessageFullCode($code))
|
||||||
|
->setSeverity($this->getLintMessageSeverity($code))
|
||||||
|
->setName($this->getLintMessageName($code))
|
||||||
|
->setDescription($desc)
|
||||||
->setOriginalText($original)
|
->setOriginalText($original)
|
||||||
->setReplacementText($replacement);
|
->setReplacementText($replacement);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue