From a4dba24c468c23f3f5fbba5f9bd8ca74d1b2618a Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@freelancer.com>
Date: Wed, 18 Nov 2015 07:19:40 +1100
Subject: [PATCH] Prevent double rendering of unit test results

Summary: D14037 had the logic slightly wrong and unit test results are now being double rendered.

Test Plan: Ran a unit test with `arc unit -- path/to/test` and saw the results rendered only once.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14495
---
 src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php b/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php
index 652a46d2..6cc659af 100644
--- a/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php
+++ b/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php
@@ -148,7 +148,9 @@ final class ArcanistConfigurationDrivenUnitTestEngine
         $all_results[] = $results;
 
         foreach ($results as $result) {
-          if ($engine->shouldEchoTestResults()) {
+          // If the proxied engine renders its own test results then there
+          // is no need to render them again here.
+          if (!$engine->shouldEchoTestResults()) {
             echo $renderer->renderUnitResult($result);
           }
         }