revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Upgrade "arc upload" to use SHA256

Browse source 
Summary: Fixes T12464. Moves "arc upload" to SHA256 where applicable.

Test Plan: Ran `arc upload` against a server with D17620 twice, saw it skip the actual upload the second time.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12464

Differential Revision: https://secure.phabricator.com/D17622
This commit is contained in:
epriestley 2017-04-04 15:52:46 -07:00
parent c4e84550fc
commit a59cfca5f1
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/upload/ArcanistFileDataRef.php
View file

@ -346,11 +346,23 @@ final class ArcanistFileDataRef extends Phobject {
} }
private function newFileHash($path) { private function newFileHash($path) {
$hash = hash_file('sha256', $path, $raw_output = false);
if ($hash === false) {
return null; return null;
} }
return $hash;
}
private function newDataHash($data) { private function newDataHash($data) {
$hash = hash('sha256', $data, $raw_output = false);
if ($hash === false) {
return null; return null;
} }
return $hash;
}
} }