revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly

Browse source 
Summary:
See PHI1862. This code calls "execute()" on the future directly, but that skips some steps -- notably, ServiceProfiler hooks.

Call "resolve()", which has the same effect but includes desirable/expected side effects.

Test Plan: Changed a workflow to run "phutil_passthru('ls')", ran it with "--trace". Before: no execution in trace; after: execution in trace.

Differential Revision: https://secure.phabricator.com/D21470
This commit is contained in:
epriestley 2020-09-18 11:19:53 -07:00
parent 563dc2a993
commit a716c4e55f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/future/exec/execx.php
View file

@ -47,7 +47,7 @@ function exec_manual($cmd /* , ... */) {
*/ */
function phutil_passthru($cmd /* , ... */) { function phutil_passthru($cmd /* , ... */) {
$args = func_get_args(); $args = func_get_args();
return newv('PhutilExecPassthru', $args)->execute(); return newv('PhutilExecPassthru', $args)->resolve();
} }