From a925ef9dc197cf069f64d25f0339855d20cc7b7e Mon Sep 17 00:00:00 2001 From: Jakub Vrana Date: Sun, 10 Mar 2013 18:08:14 -0700 Subject: [PATCH] Improve Windows compatibility Test Plan: $ arc liberate $ arc lint Reviewers: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5319 --- scripts/lib/PhutilLibraryMapBuilder.php | 2 +- src/lint/linter/ArcanistPhutilLibraryLinter.php | 2 +- src/workflow/ArcanistLiberateWorkflow.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/lib/PhutilLibraryMapBuilder.php b/scripts/lib/PhutilLibraryMapBuilder.php index 45fbdd01..3b0f31eb 100755 --- a/scripts/lib/PhutilLibraryMapBuilder.php +++ b/scripts/lib/PhutilLibraryMapBuilder.php @@ -352,7 +352,7 @@ final class PhutilLibraryMapBuilder { $absolute_file = $this->getPath($file); $bin = dirname(dirname(__FILE__)).'/phutil_symbols.php'; - return new ExecFuture('%s --ugly -- %s', $bin, $absolute_file); + return new ExecFuture('php %s --ugly -- %s', $bin, $absolute_file); } diff --git a/src/lint/linter/ArcanistPhutilLibraryLinter.php b/src/lint/linter/ArcanistPhutilLibraryLinter.php index 846e5467..0a8f772e 100644 --- a/src/lint/linter/ArcanistPhutilLibraryLinter.php +++ b/src/lint/linter/ArcanistPhutilLibraryLinter.php @@ -57,7 +57,7 @@ final class ArcanistPhutilLibraryLinter extends ArcanistLinter { // Do these one at a time since they individually fanout to saturate // available system resources. $future = new ExecFuture( - '%s --show --quiet --ugly -- %s', + 'php %s --show --quiet --ugly -- %s', $bin, phutil_get_library_root($lib)); $symbols[$lib] = $future->resolveJSON(); diff --git a/src/workflow/ArcanistLiberateWorkflow.php b/src/workflow/ArcanistLiberateWorkflow.php index 10d9ed32..4df0499d 100644 --- a/src/workflow/ArcanistLiberateWorkflow.php +++ b/src/workflow/ArcanistLiberateWorkflow.php @@ -156,7 +156,7 @@ EOTEXT $bin = $this->getScriptPath('scripts/phutil_rebuild_map.php'); return phutil_passthru( - '%s %C %s', + 'php %s %C %s', $bin, $this->getArgument('all') ? '--drop-cache' : '', $path);