From a9535446579af33dfa50f60dcc79c9edf633eebd Mon Sep 17 00:00:00 2001 From: James Rhodes Date: Thu, 17 Jul 2014 13:26:00 +1000 Subject: [PATCH] Remove "Stopped" logic from Phrequent workflows Summary: We can remove this "Stopped" code as per feedback on D7327. I think having the full text of "In Progress" and "Suspended" is much clearer than just a '*' though, so I've only removed the ongoing check. Test Plan: Ran a combination of `arc start`, `arc stop` and `arc time` and it all worked. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9955 --- src/workflow/ArcanistPhrequentWorkflow.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/workflow/ArcanistPhrequentWorkflow.php b/src/workflow/ArcanistPhrequentWorkflow.php index 6fa35ec1..d902934b 100644 --- a/src/workflow/ArcanistPhrequentWorkflow.php +++ b/src/workflow/ArcanistPhrequentWorkflow.php @@ -49,14 +49,10 @@ abstract class ArcanistPhrequentWorkflow extends ArcanistBaseWorkflow { $i = 0; foreach ($results as $result) { - if ($result['ongoing']) { - if ($i === 0) { - $column_type = 'In Progress'; - } else { - $column_type = 'Suspended'; - } + if ($i === 0) { + $column_type = 'In Progress'; } else { - $column_type = 'Stopped'; + $column_type = 'Suspended'; } $table->addRow(array(