revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Remove "Stopped" logic from Phrequent workflows

Browse source 
Summary: We can remove this "Stopped" code as per feedback on D7327.  I think having the full text of "In Progress" and "Suspended" is much clearer than just a '*' though, so I've only removed the ongoing check.

Test Plan: Ran a combination of `arc start`, `arc stop` and `arc time` and it all worked.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9955
This commit is contained in:
James Rhodes 2014-07-17 13:26:00 +10:00
parent f658f17080
commit a953544657
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workflow/ArcanistPhrequentWorkflow.php
View file

@ -49,15 +49,11 @@ abstract class ArcanistPhrequentWorkflow extends ArcanistBaseWorkflow {
$i = 0; $i = 0;
foreach ($results as $result) { foreach ($results as $result) {
if ($result['ongoing']) {
if ($i === 0) { if ($i === 0) {
$column_type = 'In Progress'; $column_type = 'In Progress';
} else { } else {
$column_type = 'Suspended'; $column_type = 'Suspended';
} }
} else {
$column_type = 'Stopped';
}
$table->addRow(array( $table->addRow(array(
'type' => '('.$column_type.')', 'type' => '('.$column_type.')',