mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 14:52:40 +01:00
Flush output before printing lint and unit results in diff
Summary: Under HPHP, output buffer size is ignored. Flush any buffered output before printing anything from `arc diff` to reduce user's confusion. Test Plan: $ arc diff --preview --background 1 $ arc diff --preview --background 0 Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3543
This commit is contained in:
parent
e1b2d787c9
commit
aa425c7ea9
1 changed files with 8 additions and 0 deletions
|
@ -1235,6 +1235,7 @@ EOTEXT
|
|||
}
|
||||
|
||||
$lint_result = $lint_workflow->run();
|
||||
$this->flushOutput();
|
||||
|
||||
switch ($lint_result) {
|
||||
case ArcanistLintWorkflow::RESULT_OKAY:
|
||||
|
@ -1307,6 +1308,7 @@ EOTEXT
|
|||
}
|
||||
$unit_workflow = $this->buildChildWorkflow('unit', $argv);
|
||||
$unit_result = $unit_workflow->run();
|
||||
$this->flushOutput();
|
||||
|
||||
switch ($unit_result) {
|
||||
case ArcanistUnitWorkflow::RESULT_OKAY:
|
||||
|
@ -1379,6 +1381,12 @@ EOTEXT
|
|||
return $return;
|
||||
}
|
||||
|
||||
private function flushOutput() {
|
||||
if ($this->getArgument('no-diff')) {
|
||||
ob_flush();
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
/* -( Commit and Update Messages )----------------------------------------- */
|
||||
|
||||
|
|
Loading…
Reference in a new issue