revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-18 11:30:54 +01:00
Code Issues Releases Wiki Activity

Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test

Browse source 
Summary:
Explicitly cast `$minutes` to int to avoid an error in PHP 8.1 and later.

```
ERROR 8192: Implicit conversion from float to int loses precision at [/var/www/html/phorge/arcanist/src/unit/renderer/ArcanistUnitConsoleRenderer.php:86]
```

Closes T15968

Test Plan: Run `bin/arc unit --everything`.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15968

Differential Revision: https://we.phorge.it/D25848
This commit is contained in:
Andre Klapper 2024-12-05 19:04:21 +01:00
parent 29ca3df112
commit abda702083
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/unit/renderer/ArcanistUnitConsoleRenderer.php
View file

@ -82,7 +82,7 @@ final class ArcanistUnitConsoleRenderer extends ArcanistUnitRenderer {
private function formatTime($seconds) {
if ($seconds >= 60) {
$minutes = floor($seconds / 60);
$minutes = (int)floor($seconds / 60);
return pht('%dm%02ds', $minutes, round($seconds % 60));
}