revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 08:42:40 +01:00
Code Issues Releases Wiki Activity

Display line number with assertion for failed test cases

Browse source 
Summary: We use custom `assert*` functions here and there. Remove them from backtrace.

Test Plan: Ran `XHPASTTreeTestCase`.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6411
This commit is contained in:
Jakub Vrana 2013-07-10 08:42:49 -07:00
parent f5ceceea87
commit ad9cb418c4
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/unit/engine/phutil/ArcanistPhutilTestCase.php
View file

@ -52,8 +52,12 @@ abstract class ArcanistPhutilTestCase {
$expect = PhutilReadableSerializer::printableValue($expect); $expect = PhutilReadableSerializer::printableValue($expect);
$result = PhutilReadableSerializer::printableValue($result); $result = PhutilReadableSerializer::printableValue($result);
$where = debug_backtrace(); foreach (debug_backtrace() as $location) {
$where = array_shift($where); if (!preg_match('/^assert[A-Z]/', idx($location, 'function'))) {
break;
}
$where = $location;
}
$line = idx($where, 'line'); $line = idx($where, 'line');
$file = basename(idx($where, 'file')); $file = basename(idx($where, 'file'));