mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-23 14:00:55 +01:00
Fix cpplint message regex
Summary: ref T8404 The issue is caused, not by the non-zero return code, but by the fact that $messages is coming back empty due to the incorrect regex. tyhoff pointed out that the regex matched correctly when we used STDIN, but now it is failing. https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistExternalLinter.php;8c589f1f759f0913135b8cc6959a6c1589e14ae4$357 Test Plan: arc lint cpp file containing lint error. run cpplint on the file directly to confirm that there are errors and that the return code is non-zero Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin Maniphest Tasks: T8404 Differential Revision: https://secure.phabricator.com/D14960
This commit is contained in:
parent
98d71571e4
commit
aeb374b333
1 changed files with 1 additions and 1 deletions
|
@ -35,7 +35,7 @@ final class ArcanistCpplintLinter extends ArcanistExternalLinter {
|
|||
foreach ($lines as $line) {
|
||||
$line = trim($line);
|
||||
$matches = null;
|
||||
$regex = '/^-:(\d+):\s*(.*)\s*\[(.*)\] \[(\d+)\]$/';
|
||||
$regex = '/(\d+):\s*(.*)\s*\[(.*)\] \[(\d+)\]$/';
|
||||
if (!preg_match($regex, $line, $matches)) {
|
||||
continue;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue