Add unit tests for ArcanistChmodLinter

Summary: Moar test coverage.

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11343

src/__phutil_library_map__.php

@@ -32,6 +32,7 @@ phutil_register_library_map(array(
     'ArcanistCapabilityNotSupportedException' => 'workflow/exception/ArcanistCapabilityNotSupportedException.php',
     'ArcanistCheckstyleXMLLintRenderer' => 'lint/renderer/ArcanistCheckstyleXMLLintRenderer.php',
     'ArcanistChmodLinter' => 'lint/linter/ArcanistChmodLinter.php',
+    'ArcanistChmodLinterTestCase' => 'lint/linter/__tests__/ArcanistChmodLinterTestCase.php',
     'ArcanistCloseRevisionWorkflow' => 'workflow/ArcanistCloseRevisionWorkflow.php',
     'ArcanistCloseWorkflow' => 'workflow/ArcanistCloseWorkflow.php',
     'ArcanistClosureLinter' => 'lint/linter/ArcanistClosureLinter.php',
@@ -239,6 +240,7 @@ phutil_register_library_map(array(
     'ArcanistCapabilityNotSupportedException' => 'Exception',
     'ArcanistCheckstyleXMLLintRenderer' => 'ArcanistLintRenderer',
     'ArcanistChmodLinter' => 'ArcanistLinter',
+    'ArcanistChmodLinterTestCase' => 'ArcanistArcanistLinterTestCase',
     'ArcanistCloseRevisionWorkflow' => 'ArcanistWorkflow',
     'ArcanistCloseWorkflow' => 'ArcanistWorkflow',
     'ArcanistClosureLinter' => 'ArcanistExternalLinter',

src/lint/linter/ArcanistChmodLinter.php

@@ -42,9 +42,11 @@ final class ArcanistChmodLinter extends ArcanistLinter {
   }
 
   public function lintPath($path) {
-    if (is_executable($path)) {
+    $engine = $this->getEngine();
-      if ($this->getEngine()->isBinaryFile($path)) {
+
-        $mime = Filesystem::getMimeType($path);
+    if (is_executable($engine->getFilePathOnDisk($path))) {
+      if ($engine->isBinaryFile($path)) {
+        $mime = Filesystem::getMimeType($engine->getFilePathOnDisk($path));
 
         switch ($mime) {
           // Archives

src/lint/linter/__tests__/ArcanistChmodLinterTestCase.php

@@ -0,0 +1,9 @@
+<?php
+
+final class ArcanistChmodLinterTestCase extends ArcanistArcanistLinterTestCase {
+
+  public function testLinter() {
+    $this->executeTestsInDirectory(dirname(__FILE__).'/chmod/');
+  }
+
+}

src/lint/linter/__tests__/ArcanistLinterTestCase.php

@@ -86,6 +86,7 @@ abstract class ArcanistLinterTestCase extends ArcanistPhutilTestCase {
         'hook' => 'optional bool',
         'config' => 'optional map<string, wild>',
         'path' => 'optional string',
+        'mode' => 'optional string',
       ));
 
     $exception = null;
@@ -99,6 +100,11 @@ abstract class ArcanistLinterTestCase extends ArcanistPhutilTestCase {
       Filesystem::writeFile($tmp, $data);
       $full_path = (string)$tmp;
 
+      $mode = idx($config, 'mode');
+      if ($mode) {
+        Filesystem::changePermissions($tmp, octdec($mode));
+      }
+
       $dir = dirname($full_path);
       $path = basename($full_path);
 

src/lint/linter/__tests__/chmod/empty_executable.lint-test

@@ -0,0 +1,5 @@
+~~~~~~~~~~
+warning::
+~~~~~~~~~~
+~~~~~~~~~~
+{"mode": "0755"}

src/lint/linter/__tests__/chmod/shebang.lint-test

@@ -0,0 +1,5 @@
+#!/bin/bash
+~~~~~~~~~~
+~~~~~~~~~~
+~~~~~~~~~~
+{"mode": "0755"}