From b22e94d5550f3b906738cdf1c090f0798521d017 Mon Sep 17 00:00:00 2001 From: vrana Date: Tue, 25 Sep 2012 17:57:01 -0700 Subject: [PATCH] Don't run background process with raw diff source Test Plan: $ arc diff Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3553 --- src/workflow/ArcanistDiffWorkflow.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php index 9bbe7e7f..bf3d7d7a 100644 --- a/src/workflow/ArcanistDiffWorkflow.php +++ b/src/workflow/ArcanistDiffWorkflow.php @@ -377,7 +377,10 @@ EOTEXT $this->runDiffSetupBasics(); - $background = $this->getArgument('background', !phutil_is_windows()); + $background = $this->getArgument('background', true); + if ($this->isRawDiffSource() || phutil_is_windows()) { + $background = false; + } if ($background) { $argv = $this->getPassedArguments();