mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-29 18:22:41 +01:00
Catch ArcanistUsageException when getting git parent log info
Summary: ArcanistDiffWorkflow::getGitParentLogInfo() calls ArcanistDifferentialCommitMessage::newFromRawCorpus() which may throw a ArcanistUsageException if the parent commit message is malformed (specifically, a bad "Differential Revision:" line); this should not stop arc diff. Test Plan: successfully ran arc diff where the parent commit message was malformed. Reviewers: epriestley, jungejason Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2434
This commit is contained in:
parent
b8b4082efd
commit
b34915020e
1 changed files with 2 additions and 0 deletions
|
@ -996,6 +996,8 @@ EOTEXT
|
||||||
}
|
}
|
||||||
} catch (ArcanistDifferentialCommitMessageParserException $ex) {
|
} catch (ArcanistDifferentialCommitMessageParserException $ex) {
|
||||||
// Ignore.
|
// Ignore.
|
||||||
|
} catch (ArcanistUsageException $ex) {
|
||||||
|
// Ignore an invalid Differential Revision field in the parent commit
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue